Skip to content

Commit

Permalink
Fix php unit tests (after variations api change) (#58090)
Browse files Browse the repository at this point in the history
  • Loading branch information
ellatrix authored Jan 22, 2024
1 parent b9e3c9f commit b2c2a08
Showing 1 changed file with 8 additions and 4 deletions.
12 changes: 8 additions & 4 deletions packages/block-library/src/navigation-link/index.php
Original file line number Diff line number Diff line change
Expand Up @@ -338,7 +338,10 @@ function block_core_navigation_link_register_variation( $variation ) {
return;
}

$navigation_block_type->variations[] = $variation;
$navigation_block_type->variations = array_merge(
$navigation_block_type->variations,
array( $variation )
);
}

/**
Expand All @@ -355,15 +358,16 @@ function block_core_navigation_link_unregister_variation( $name ) {
if ( ! $navigation_block_type || empty( $navigation_block_type->variations ) ) {
return;
}
$variations = $navigation_block_type->variations;
// Search for the variation and remove it from the array.
foreach ( $navigation_block_type->variations as $i => $variation ) {
foreach ( $variations as $i => $variation ) {
if ( $variation['name'] === $name ) {
unset( $navigation_block_type->variations[ $i ] );
unset( $variations[ $i ] );
break;
}
}
// Reindex array after removing one variation.
$navigation_block_type->variations = array_values( $navigation_block_type->variations );
$navigation_block_type->variations = array_values( $variations );
}

/**
Expand Down

0 comments on commit b2c2a08

Please sign in to comment.