-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Documentation] Add examples for core/data
package
#42639
Draft
ryanwelcher
wants to merge
14
commits into
trunk
Choose a base branch
from
feature/add-examples-for-core-data
base: trunk
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Changes from 10 commits
Commits
Show all changes
14 commits
Select commit
Hold shift + click to select a range
3fab15b
Adds examples for the following selectors:
ryanwelcher c89ac94
Merge branch 'trunk' into feature/add-examples-for-core-data
ryanwelcher 91f0a28
Add example for getCurrentUser selector.
ryanwelcher f41aa05
Add example for getEntityRecord.
ryanwelcher c794120
Add example for getEntityRecords.
ryanwelcher 4d70a55
Add example for getEmbedPreview.
ryanwelcher fac66cc
Merge branch 'trunk' into feature/add-examples-for-core-data
ryanwelcher 57619a7
Merge branch 'trunk' into feature/add-examples-for-core-data
ryanwelcher 5261a7e
Add example for isRequestingEmbedPreview.
ryanwelcher b4d3190
Merge branch 'trunk' into feature/add-examples-for-core-data
ryanwelcher 1cfb5db
Merge branch 'trunk' into feature/add-examples-for-core-data
ryanwelcher f02334d
Merge branch 'trunk' into feature/add-examples-for-core-data
ryanwelcher b89320c
Merge branch 'trunk' into feature/add-examples-for-core-data
ryanwelcher c5b24f6
Add example for useEntityProp.
ryanwelcher File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should consider marking
getEntityRecord
andgetEntityRecords
selectors as internal and promote related React hooksuseEntityRecord
anduseEntityRecords
instead. Those selectors still could be useful outside of React components, though. @adamziel, what do you think?Maybe there is a way to reference those two concepts in some nice way.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These selectors are used across many
@wordpress
packages, unfortunately React hooks won't work in custom store actions.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a great idea! They're more succinct and easier to think of than
useSelect
+getEntityRecord