[Documentation] Add examples for core/data package
#42639
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
canUser canUserEditEntityRecord getCurrentTheme getAutosave getAutosaves getBlockPatterns getBlockPatternCategories
ryanwelcher
added
[Type] Developer Documentation
19 tasks
gziolo
reviewed
Jul 26, 2022
| const ExampleComponent = () => { | ||
| const { postData, termData } = useSelect( ( select ) => { | ||
| return { | ||
| postData: select( coreDataStore ).getEntityRecord( |
There was a problem hiding this comment.
We should consider marking getEntityRecord and getEntityRecords selectors as internal and promote related React hooks useEntityRecord and useEntityRecords instead. Those selectors still could be useful outside of React components, though. @adamziel, what do you think?
Maybe there is a way to reference those two concepts in some nice way.
There was a problem hiding this comment.
These selectors are used across many @wordpress packages, unfortunately React hooks won't work in custom store actions.
There was a problem hiding this comment.
promote related React hooks useEntityRecord and useEntityRecords instead.
This is a great idea! They're more succinct and easier to think of than useSelect + getEntityRecord
gziolo
reviewed
Jul 26, 2022
|
Flaky tests detected in f02334d. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/5658275236
|
|
Size Change: 0 B Total Size: 1.75 MB ℹ️ View Unchanged
|
|
Would love to see this live in the docs! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
This PR adds examples for the the
core/datapackage docs. Part of #42125