Update justification control in flex layout#34651
Merged
ntsekouras merged 2 commits intotrunkfrom Sep 9, 2021
Merged
Conversation
|
Size Change: +53 B (0%) Total Size: 1.04 MB
ℹ️ View Unchanged
|
jasmussen
approved these changes
Sep 8, 2021
Contributor
jasmussen
left a comment
jasmussen
left a comment
There was a problem hiding this comment.
As described, I see the new buttongroup toggles for justification in the inspector, just like in the block toolbar, works well:
Giving tentative approval so we can land this as it's a big improvement over what's there. However I did leave one comment about how ideally we avoid adding unique classnames and writing CSS just for this one panel if we can. Ideally we find a way to make panels handle their form controls inside in a generalized way. Possibly a larger effort, but nevertheless a worthwhile one, so we don't proliferate the edgecase CSS.
Thanks so much for the fast followup 👌
|
|
||
| .block-editor-hooks__flex-layout-justification-controls { | ||
| legend { | ||
| margin-bottom: 8px; |
Contributor
There was a problem hiding this comment.
8px can be replaced by $grid-unit-10. But a larger question is, can this be handled in a more global fashion, rather than creating per-panel custom CSS? Ideally we slowly move towards generic reusable and systematized form controls as outlined in #27331, to avoid bespoke CSS like this.
Contributor
Author
There was a problem hiding this comment.
Totally agree but as you mentioned and know it's a larger effort and this follow up is an enhancement to the current one!
Contributor
There was a problem hiding this comment.
As long as we remember to circle back and clean up all this stuff 👍 👍
Contributor
Author
There was a problem hiding this comment.
It's going to be hard to miss unfortunately as there are many controls that needs consolidation 😞
Contributor
There was a problem hiding this comment.
Even a thousand mile journey starts with one step!
ntsekouras
deleted the
update/justification-control-in-flex-inspector-controls
branch
getsource
pushed a commit
that referenced
this pull request
Sep 9, 2021
fullofcaffeine
added a commit
that referenced
this pull request
Sep 9, 2021
* trunk: [RNMobile][Embed block] Add device's locale to preview content (#33858) Update AlignmentMatrixControl docs post merge. (#34662) Chore: Update caniuse package to the latest version (#34685) Chore: Move `react-native-url-polyfill` to dev dependencies (#34687) Site Editor - add basic plugin support (#34460) ESLint Plugin: Use Jest related rules only when the package is installed (#33120) Update `@wordpress/components` package's contributing guidelines (#33960) chore(release): publish Update changelog files [RNMobile] [Embed block] Fix content disappearing on Android when switching light/dark mode (#34207) Scripts: Convert legacy entry point arguments for compatibility with webpack 5 (#34264) Update justication control in `flex` layout (#34651) Block Editor: Rename experimental prop used in `BlockControls` (#34644) Fix social links deprecation (#34639)
ntsekouras
changed the title
flex layoutflex layout
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow up of: #34493
This PR updates the
justificationcontrol in inspector controls.based on @jasmussen proposal:
Notes
I haven't used
ToggleGroupControlfor this because it needs some enhancements to supporticonsinstead ofstringlabels. When this is implemented we should consider changing again.