Merged
Conversation
|
Size Change: +3 B (0%) Total Size: 1.04 MB
ℹ️ View Unchanged
|
ntsekouras
added
the
[Block] Social
aaronrobertshaw
approved these changes
Sep 9, 2021
Contributor
aaronrobertshaw
left a comment
aaronrobertshaw
left a comment
There was a problem hiding this comment.
Thanks for the quick fix @ntsekouras 👍
This tests well for me.
✅ Supports added to the deprecation match those prior to #34493
✅ Migrating a social links block from prior to #34493 no longer detects alignment classes as custom CSS classes
✅ Adjusting alignments of migrated social links blocks works again
getsource
pushed a commit
that referenced
this pull request
Sep 9, 2021
fullofcaffeine
added a commit
that referenced
this pull request
Sep 9, 2021
* trunk: [RNMobile][Embed block] Add device's locale to preview content (#33858) Update AlignmentMatrixControl docs post merge. (#34662) Chore: Update caniuse package to the latest version (#34685) Chore: Move `react-native-url-polyfill` to dev dependencies (#34687) Site Editor - add basic plugin support (#34460) ESLint Plugin: Use Jest related rules only when the package is installed (#33120) Update `@wordpress/components` package's contributing guidelines (#33960) chore(release): publish Update changelog files [RNMobile] [Embed block] Fix content disappearing on Android when switching light/dark mode (#34207) Scripts: Convert legacy entry point arguments for compatibility with webpack 5 (#34264) Update justication control in `flex` layout (#34651) Block Editor: Rename experimental prop used in `BlockControls` (#34644) Fix social links deprecation (#34639)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow up on: #34493
I had missed the
supportsfield in the new deprecation of the block. It should now work properly.Regarding: #34493 (comment)
@aaronrobertshaw can you verify that now this is working properly?