Gallery block: Fix media placeholder height in site editor#34629
Merged
andrewserong merged 1 commit intotrunkfrom Sep 8, 2021
Merged
Gallery block: Fix media placeholder height in site editor#34629andrewserong merged 1 commit intotrunkfrom
andrewserong merged 1 commit intotrunkfrom
Conversation
andrewserong
added
[Type] Bug
|
Size Change: +18 B (0%) Total Size: 1.04 MB
ℹ️ View Unchanged
|
Mamaduka
approved these changes
Sep 8, 2021
Member
Mamaduka
left a comment
Mamaduka
left a comment
There was a problem hiding this comment.
Thanks for catching this, @andrewserong.
It is an interesting issue. I can only reproduce it on TT1 Blocks. It works as expected on Blockbase.
Approving since I don't see any possible regressions with this change.
glendaviesnz
approved these changes
Sep 8, 2021
Contributor
glendaviesnz
left a comment
glendaviesnz
left a comment
There was a problem hiding this comment.
This tested well for me with:
✅ Chrome, Firefox, Safari
✅ With gallery experiment toggled off and adding gallery to site editor and posts
✅ With gallery experiment toggled on and adding gallery to site editor and posts
andrewserong
deleted the
fix/non-refactored-gallery-media-placeholder-height
branch
fullofcaffeine
added a commit
that referenced
this pull request
Sep 9, 2021
* trunk: (214 commits) Fix snackbar overflow on nav editor (#34661) Mobile - Allow disabling text and background color via theme.json (#34633) Fix disabled blocks logical error on Widgets screen (#34634) [Mobile] - Global styles - Add support to render font sizes and line height (#34144) ESLint Plugin: Update eslint jsdoc dependency (#34338) Scripts: Add CHANGELOG entry for `jest-dev-server` upgrade (#34657) Bump jest-dev-server to v5 (#34560) Refactor the `core-data` store to thunks (#28389) Only capture toolbars on parent Nav block when not in vertical mode (#34615) Update Changelog for 11.5.0-rc.1 Bump plugin version to 11.5.0-rc.1 Gallery block: Fix media placeholder height in site editor (#34629) Border Controls: Display color indicator and check selected color (#34467) Remove horizontal and vertical navigation block variations from inserter (#34614) AlignmentMatrixControl : Fix/update docs (#34624) Gap block support: force gap change to cause the block to re-render (fix Safari issue) (#34567) [Block Library - Social Links]: Use the new `flex` layout (#34493) [Mobile] Update the bottom sheet header (#34309) Group block: Add a row variation (#34535) Migrate entities.js to thunks (#34582) ...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
While testing #34606, I noticed that the placeholder for adding media to an existing v1 gallery block (i.e. the non-experimental refactored gallery) was rendering too high vertically in the site editor, when the gallery block is inserted as a child of a template part.
This PR removes the
height: 100%setting for the placeholder, and I haven't found any issues so far in removing it, but I'm not sure if there was a reason why it might be needed.How has this been tested?
Manually:
Without this PR applied and running TT1-blocks theme:
Screenshots
Types of changes
Bug fix (non-breaking change which fixes an issue)
Checklist:
*.native.jsfiles for terms that need renaming or removal).