Merged
Conversation
|
Size Change: +130 B (0%) Total Size: 1.04 MB
ℹ️ View Unchanged
|
adamziel
force-pushed
the
update/migrate-entities-to-thunks
branch
from
1f6d772 to
2c3eded
Compare
Contributor
Author
|
This will need a rebase once the other thunks-related PRs land |
jsnajdr
force-pushed
the
update/migrate-entities-to-thunks
branch
from
2c3eded to
326b4d0
Compare
jsnajdr
approved these changes
Sep 7, 2021
Member
jsnajdr
left a comment
jsnajdr
left a comment
There was a problem hiding this comment.
The changes look good and are identical to my version. But many CI checks are failing. I rebased and pushed the branch -- let's see if that makes things better.
adamziel
force-pushed
the
update/migrate-entities-to-thunks
branch
from
a089a0f to
90021e3
Compare
getsource
added
[Package] Core data
fullofcaffeine
added a commit
that referenced
this pull request
Sep 9, 2021
* trunk: (214 commits) Fix snackbar overflow on nav editor (#34661) Mobile - Allow disabling text and background color via theme.json (#34633) Fix disabled blocks logical error on Widgets screen (#34634) [Mobile] - Global styles - Add support to render font sizes and line height (#34144) ESLint Plugin: Update eslint jsdoc dependency (#34338) Scripts: Add CHANGELOG entry for `jest-dev-server` upgrade (#34657) Bump jest-dev-server to v5 (#34560) Refactor the `core-data` store to thunks (#28389) Only capture toolbars on parent Nav block when not in vertical mode (#34615) Update Changelog for 11.5.0-rc.1 Bump plugin version to 11.5.0-rc.1 Gallery block: Fix media placeholder height in site editor (#34629) Border Controls: Display color indicator and check selected color (#34467) Remove horizontal and vertical navigation block variations from inserter (#34614) AlignmentMatrixControl : Fix/update docs (#34624) Gap block support: force gap change to cause the block to re-render (fix Safari issue) (#34567) [Block Library - Social Links]: Use the new `flex` layout (#34493) [Mobile] Update the bottom sheet header (#34309) Group block: Add a row variation (#34535) Migrate entities.js to thunks (#34582) ...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Builds on top of the thunks support added in #27276 and refactors just the parts of core-data required to make the functions from
entities.jswork (this PR is a minimal viable subset of #28389 with unit tests adjusted).Test plan: