-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[RNMobile] react native bridge UBE path fix #30650
Merged
jd-alexander
merged 4 commits into
trunk
from
rnmobile/react-native-bridge-asset-path-issue
Apr 9, 2021
Merged
[RNMobile] react native bridge UBE path fix #30650
jd-alexander
merged 4 commits into
trunk
from
rnmobile/react-native-bridge-asset-path-issue
Apr 9, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jd-alexander
added
the
Mobile App - i.e. Android or iOS
Native mobile impl of the block editor. (Note: used in scripts, ping mobile folks to change)
label
Apr 9, 2021
2 tasks
Size Change: 0 B Total Size: 1.42 MB ℹ️ View Unchanged
|
guarani
approved these changes
Apr 9, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested in WPAndroid and working! Thanks a lot, @jd-alexander !
guarani
pushed a commit
that referenced
this pull request
Apr 9, 2021
* Fixed the asset path for the unsupported-block-editor * symlink update.
This was referenced Apr 9, 2021
guarani
added a commit
that referenced
this pull request
Apr 10, 2021
* Release script: Update react-native-editor version to 1.50.0 * Release script: Update with changes from 'npm run core preios' * Gutenberg Plugin: Remove deprecations planned for 10.3 release (#30417) * Gutenberg Plugin: Remove deprecations planned for 10.3 release * Docs: Add changelog entry * Closed changelog for 1.50.0 * Release script: Update react-native-editor version to 1.50.1 * Release script: Update with changes from 'npm run core preios' * RNMobile: Truncate rangecell screenreader decimals (#30678) Screenreaders (VoiceOver and TalkBack) were reading values of range-cells with too much precision. For example, a Column block with three columns would read widths as 33.33333333 when it should be read as 33.3. * [RNMobile] react native bridge UBE path fix (#30650) * Fixed the asset path for the unsupported-block-editor * symlink update. * Use the default div tagName on native (#30645) Co-authored-by: Ceyhun Ozugur <ceyhunozugur@gmail.com> * Fix crash from non-adjustable unit RangeCell a11y activation (#30636) * Avoid invoking possible null callback Previously, the unit picker callback was always invoked when a11y tools activated the element. This caused the app to crash whenever the element did not have adjustable units. * Add test coverage for RangeCell accessibility actions * Re-added symlink update. * Update changelog for react-native-editor Co-authored-by: Greg Ziółkowski <grzegorz@gziolo.pl> Co-authored-by: Joel Dean <jdeanjj1000@gmail.com> Co-authored-by: Ceyhun Ozugur <ceyhunozugur@gmail.com> Co-authored-by: David Calhoun <dpcalhoun@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Mobile App - i.e. Android or iOS
Native mobile impl of the block editor. (Note: used in scripts, ping mobile folks to change)
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Gutenberg Mobile PR wordpress-mobile/gutenberg-mobile#3353
Description
During the composite build project, changes made here #28216 caused the UBE path to be broken so this PR seeks to address this by including the additional
../
needed in the path to resolve the UBE assets needed by the editor.This PR also builds on top of the broken symlink that links the assets in
react-native-bridge
. Those changes were merged in here #30388The symlink was updated in this PR as well, as it was still broken even though the diff changes look near similar.
How has this been tested?
Types of changes
The
assets.srcDirs
path pointing to theresources/unsupported-block-editor
folder withgutenberg-mobile
was updated.Checklist:
*.native.js
files for terms that need renaming or removal).