Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RNMobile] Fix path in gutenberg-web-single-block symlink. #30388

Merged
merged 1 commit into from
Apr 9, 2021

Conversation

iandunn
Copy link
Member

@iandunn iandunn commented Mar 30, 2021

Description

#22714 created packages/react-native-bridge/android/react-native-bridge/src/main/assets/gutenberg-web-single-block, but it looks like the symlink points one folder above where it's intended.

../../../../common/gutenberg-web-single-block       -> packages/react-native-bridge/android/common/gutenberg-web-single-block
../../../../../../common/gutenberg-web-single-block -> packages/react-native-bridge/common/gutenberg-web-single-block

Adding an extra ../ should fix it.

cc @Tug

How has this been tested?

  1. git checkout trunk
  2. cd packages/react-native-bridge/android/react-native-bridge/src/main/assets
  3. ls gutenberg-web-single-block, see error that target doesn't exist
  4. git checkout {this branch}
  5. ls gutenberg-web-single-block, see that target exists

I haven't tested beyond that, since I'm not familiar with the mobile side of things. I encountered this when trying to test a GitHub workflow locally with https://github.com/nektos/act/, and got an error from Docker when trying to copy the symlink to its temporary folder. The changes in this PR fixed that.

Types of changes

Bug fix (non-breaking change which fixes an issue)

Checklist:

  • My code is tested.
  • My code follows the WordPress code style.
  • My code follows the accessibility standards.
  • I've tested my changes with keyboard and screen readers.
  • My code has proper inline documentation.
  • I've included developer documentation if appropriate.
  • I've updated all React Native files affected by any refactorings/renamings in this PR (please manually search all *.native.js files for terms that need renaming or removal).

@Tug
Copy link
Contributor

Tug commented Apr 8, 2021

Just noticed the ping here sorry! @hypest do you mind having a look at it?

@jd-alexander jd-alexander self-requested a review April 8, 2021 22:08
@jd-alexander jd-alexander added the Mobile App - i.e. Android or iOS Native mobile impl of the block editor. (Note: used in scripts, ping mobile folks to change) label Apr 8, 2021
@jd-alexander
Copy link
Contributor

jd-alexander commented Apr 8, 2021

Thanks for this fix @iandunn these changes will be merged into trunk and also shipped as part of a beta release on top of gutenberg-mobile release 1.50 wordpress-mobile/gutenberg-mobile#3324

I will be running some tests and creating supplementary mobile PRs to verify the fix.

Copy link
Contributor

@jd-alexander jd-alexander left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@iandunn I tested the symlink fix and the symlink now functions as expected. I will be creating an additional PR to resolve the referenced issues we discovered otherwise. Thanks again for spotting this. LGTM 🚢

@jd-alexander jd-alexander merged commit 3abc663 into WordPress:trunk Apr 9, 2021
@github-actions github-actions bot added this to the Gutenberg 10.5 milestone Apr 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Mobile App - i.e. Android or iOS Native mobile impl of the block editor. (Note: used in scripts, ping mobile folks to change)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants