Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Restore gray background. #27188

Merged
merged 2 commits into from
Nov 25, 2020
Merged

Restore gray background. #27188

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1a19fb6
Restore gray background.
jasmussen Nov 23, 2020
42e277d
Make linter happy
ellatrix Nov 25, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions packages/edit-post/src/components/visual-editor/style.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,5 @@
.edit-post-visual-editor {
position: relative;
// Default background color so that grey .edit-post-editor-regions__content color doesn't show through.
background-color: $white;

// The button element easily inherits styles that are meant for the editor style.
// These rules enhance the specificity to reduce that inheritance.
Expand All @@ -28,6 +26,10 @@
}

.editor-styles-wrapper {
// Default background color so that grey .edit-post-editor-regions__content
// color doesn't show through.
background-color: $white;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems the background is still valuable if the theme does not provide one, so I moved it to the .editor-styles-wrapper (the canvas), which can be be overridden.


cursor: text;

> * {
Expand Down