Restore gray background. #27188
Merged
Restore gray background. #27188
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jasmussen
added
the
[Type] Regression
|
Size Change: +4 B (0%) Total Size: 1.2 MB
ℹ️ View Unchanged
|
ellatrix
force-pushed
the
try/restore-gray-background
branch
from
f619ac5
to
1a19fb6
Compare
ellatrix
reviewed
Nov 25, 2020
| @@ -28,6 +26,10 @@ | |||
| } | |||
|
|
|||
| .editor-styles-wrapper { | |||
| // Default background color so that grey .edit-post-editor-regions__content | |||
| // color doesn't show through. | |||
| background-color: $white; | |||
There was a problem hiding this comment.
It seems the background is still valuable if the theme does not provide one, so I moved it to the .editor-styles-wrapper (the canvas), which can be be overridden.
ellatrix
approved these changes
Nov 25, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The gray background that appears behind the editor styles canvas disappeared as part of #27035. This PR restores that, to help make responsive previews clear. Before:
After:
Note, the double scrollbar is a separate/pre-existing issue. I did try an experiment that removes the explicit height and allowed overflow-y on the preview box, and it works well:
however I also assume that there's a very good reason that explicit height is there in the first place, and will be even more necessary if/when the whole thing is boxed in an iframe. CC: @tellthemachines