Create Block: Enable loading translations for created blocks #24125
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This function tells WordPress that there are translations for the corresponding script file. Without it, the JSON translations are not loaded.
ryelle
requested review from
ajitbohra,
chrisvanpatten,
gziolo and
mkaz
as code owners
|
Size Change: +1.55 kB (0%) Total Size: 1.16 MB
ℹ️ View Unchanged
|
ocean90
reviewed
Jul 27, 2020
docs/designers-developers/developers/tutorials/create-block/wp-plugin.md
Outdated
Show resolved
Hide resolved
|
@ryelle, thank you very much for the patch 💯 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Currently,
create-blockcreates a plugin using i18n, but it doesn't attach the translations to the script. This PR adds a call towp_set_script_translationsto both templates, to ensure that translations will be injected into the page.I also added a note into the create-block tutorial, but since the next step explains what i18n is, I left it very basic.
How has this been tested?
Ran the create-block script locally, and ensured that the
*-js-translationsscript tag was output on the page.