Skip to content

[FIX] agentEndedChat Flag based on reason received in ChatEnded #69

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
ear-dev merged 2 commits into from
Aug 19, 2022
Merged

[FIX] agentEndedChat Flag based on reason received in ChatEnded #69

ear-dev merged 2 commits into from
Aug 19, 2022

Conversation

@Shailesh351
Copy link
Collaborator

@Shailesh351 Shailesh351 commented Aug 19, 2022

@AlexanderKanakis
Copy link
Collaborator

AlexanderKanakis commented Aug 19, 2022

We have some lint errors.

AlexanderKanakis
AlexanderKanakis approved these changes Aug 19, 2022
View reviewed changes
Copy link
Collaborator

@AlexanderKanakis AlexanderKanakis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ear-dev
Copy link

ear-dev commented Aug 19, 2022

@Shailesh351 To clarify for me please...... This PR fixes the issue where our 'agentEndedChat' flag was not correct because it was always being set to true? But our messaging in the transcript window will still show either "Chat closed by visitor" or "Closed by visitor"........ and we will fix that in the other PR? thanks

@Shailesh351
Copy link
Collaborator Author

Shailesh351 commented Aug 19, 2022

@Shailesh351 To clarify for me please...... This PR fixes the issue where our 'agentEndedChat' flag was not correct because it was always being set to true? But our messaging in the transcript window will still show either "Chat closed by visitor" or "Closed by visitor"........ and we will fix that in the other PR? thanks

Yes, exactly....

@ear-dev
Copy link

ear-dev commented Aug 19, 2022

@Shailesh351 To clarify for me please...... This PR fixes the issue where our 'agentEndedChat' flag was not correct because it was always being set to true? But our messaging in the transcript window will still show either "Chat closed by visitor" or "Closed by visitor"........ and we will fix that in the other PR? thanks

Yes, exactly....

ok, cool..... thanks

@ear-dev ear-dev merged commit 126bd80 into master Aug 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@AlexanderKanakis AlexanderKanakis AlexanderKanakis approved these changes

@bhardwajaditya bhardwajaditya Awaiting requested review from bhardwajaditya

@csmith14 csmith14 Awaiting requested review from csmith14

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[BUG][SF] agentEndedFlag is true when chat ended by visitor

3 participants

@Shailesh351 @AlexanderKanakis @ear-dev