Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Log escalation failure if SF bot is offline/disabled #56

Merged
merged 2 commits into from
Apr 29, 2021

Conversation

itzzritik
Copy link

@itzzritik itzzritik commented Apr 20, 2021

This PR contains the log escalation failure if SF bot is offline/disabled:

Steps to reproduce these changes

  1. Make sure that Salesforce Bot is offline, if not log out from the Salesforce bot.
  2. Disabling the bot will have a similar effect as it will make the bot offline.
  3. That's it, now try to escalate the case from livechat widget.
  4. It should fail and log the error Failed to handover, as shown below

Screenshot of the logpoint

image

lib/Room.ts Outdated
targetDepartment: livechatTransferData.targetDepartment
}

console.log('Failed to handover', handoverFailure);
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@itzzritik can you use this from now on when we add new log points please..... JSON.stringify(handoverFailure)

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Understood, will take care

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks.... I'll test

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@itzzritik I'm not yet able to get this to work.... maybe tomorrow you can demo for us how this should work.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ear-dev I have updated the description, with steps to reproduce, please have a look.

@ear-dev
Copy link

ear-dev commented Apr 26, 2021

@itzzritik can you be more precise when you say "Make sure that Salesforce Bot is offline, if not log out from the Salesforce bot."?

  • Do you mean that the "salesforce-live-agent-integration.bot" user is offline?
  • Do you mean that the "Salesforce Live Agent Integration" app is disabled?

Also, in the case where the Dialogflow app is misconfigured to handover to a department that does not exist, will this trigger the failed handover event?

Can you confirm other scenarios as well please:

  • salesforce app has no available agents
  • salesforce app is broken/frozen
  • salesforce app is misconfigured so that it cannot talk to the salesforce backend properly

I know that there are a lot of edge cases......

Can you please create a document that describes every case where your failed to handover log points will be triggered?
I'll make a story about that.

@itzzritik
Copy link
Author

@ear-dev That's a great plan, would be better to keep everything at a place.
I will surely make a document capturing all Failed to Handover events.
and I'm aware that this task is being tracked here.
Thanks!

@ear-dev ear-dev merged commit d3a1b0b into master Apr 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants