Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Monorepo approach #247

Merged
merged 14 commits into from
Sep 25, 2022
Merged

Conversation

Cahllagerfeld
Copy link
Member

@Cahllagerfeld Cahllagerfeld commented Sep 21, 2022

closes #242
based on #246

  • migrate logic
  • delete old tests
  • create new tests
  • add changeset

@changeset-bot
Copy link

changeset-bot bot commented Sep 21, 2022

🦋 Changeset detected

Latest commit: 906c94f

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages
Name Type
@webstone/cli Minor
create-webstone-app Minor
@webstone/core Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

...prepareProjectStructureTasks,
...installAppDependenciesTasks,
],
[...createAppDirectoryTasks, ...installAppDependenciesTasks, ...configureApp],
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm surprised Prettier is ok with all that on a single line 🤔

Copy link
Collaborator

@mikenikles mikenikles left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's in draft I see. 👍 for what's in here, so I'll approve to avoid being a bottleneck.

@mikenikles mikenikles mentioned this pull request Sep 24, 2022
2 tasks
@Cahllagerfeld
Copy link
Member Author

I'd love to get the gluegun thing done first, so we don't end up with a failing release again (cli is affected here again). That's the reason behind it 👍

Base automatically changed from cahllagerfeld/pin-version-of-playwright-243 to main September 25, 2022 07:52
@Cahllagerfeld Cahllagerfeld marked this pull request as ready for review September 25, 2022 10:15
@Cahllagerfeld Cahllagerfeld marked this pull request as draft September 25, 2022 14:23
@Cahllagerfeld Cahllagerfeld marked this pull request as ready for review September 25, 2022 15:54
@Cahllagerfeld Cahllagerfeld merged commit f7a4f1f into main Sep 25, 2022
@Cahllagerfeld Cahllagerfeld deleted the cahllagerfeld/242-remove-monorepo branch September 25, 2022 16:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Get Rid of Monorepo
2 participants