Convert Sveltekit to Webstone App #233
Conversation
🦋 Changeset detectedLatest commit: 9353002 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
| "node_modules", | ||
| "build", | ||
| ".svelte-kit", | ||
| "package", | ||
| "package-lock.json", | ||
| "yarn.lock", |
There was a problem hiding this comment.
How would we handle this? I think we can take the .gitignore as reference for folders and files that don't matter when copying. The question are lockfiles from package managers: Do we delete them? As we are using the pnpm we can't keep then, but this might cause trouble when installing the project dependencies. What do you think @mikenikles?
There was a problem hiding this comment.
I think it's fair to say this is no longer an issue once we merge #247, agreed?
| const fakeFsExistsSync = sinon.stub(); | ||
| fakeFsExistsSync.onFirstCall().returns(true); | ||
| fakeFsExistsSync.onSecondCall().returns(false); |
There was a problem hiding this comment.
That's a workaround, as the isSveltekit function can't be faked properly (its a named export from an esmodule). That's why I'm faking the specific calls of the stub.
That's definitely not ideal, and just a workaround
|
This is no longer needed now that Webstone is an ecosystem of plugins. To add Webstone to a SvelteKit app, you just need to add the Webstone CLI package. |
closes #232