Skip to content

Fix #2359: Fix typo in VUMeterNode #2360

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Aug 26, 2021
Merged

Fix #2359: Fix typo in VUMeterNode #2360

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
05ae4ec
Fix #2359: Fix typo in VUMeterNode
Jun 25, 2021
9204119
Don't need fixup.js; remove unneeded blank line
Jun 29, 2021
0e1565b
Add changelist bits to the change
padenot Aug 26, 2021
03ad5ef
Merge branch 'main' into 2359-fix-typo-vumeter-example
hoch Aug 26, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 13 additions & 3 deletions index.bs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -171,6 +171,7 @@ function InsertButtons(node) {
window.addEventListener('load', (event) => {
// Add entries here for each change
ListAmendments("c2361", "Proposed Correction", "change-list-2361");
ListAmendments("c2359", "Proposed Correction", "change-list-2359");
ListAmendments("c2373", "Proposed Correction", "change-list-2373");
});
</script>
Expand Down Expand Up @@ -11073,7 +11074,13 @@ communication (asynchronous) between
{{AudioWorkletNode}} and
{{AudioWorkletProcessor}}. This node does not use any output.

<xmp line-numbers class="example" highlight="js" title="VUMeterNode - Global Scope (vumeternode.js)">
<div class="correction" id="c2359">
<span class="marker">Candidate Correction
<a href="https://github.com/WebAudio/web-audio-api/issues/2359">Issue 2359.</a>
</span>
Fix typo in code; semi-colon is incorrect.
</div>
<pre line-numbers class="example" highlight="js" title="VUMeterNode - Global Scope (vumeternode.js)">
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needed to change xmp to pre so that the del markup works to show what was deleted.

/* vumeter-node.js: Main global scope */

export default class VUMeterNode extends AudioWorkletNode {
Expand All @@ -11083,7 +11090,7 @@ export default class VUMeterNode extends AudioWorkletNode {
numberOfOutputs: 0,
channelCount: 1,
processorOptions: {
updateIntervalInMS: updateIntervalInMS || 16.67;
updateIntervalInMS: updateIntervalInMS || 16.67<del cite=#c2359>;</del>
}
});

Expand Down Expand Up @@ -11113,7 +11120,7 @@ export default class VUMeterNode extends AudioWorkletNode {
// every |this._updateIntervalInMS| milliseconds.
}
};
</xmp>
</pre>

<xmp line-numbers class="example" highlight="js" title="VUMeterNode - AudioWorkletGlobalScope (vumeterprocessor.js)">
/* vumeter-processor.js: AudioWorkletGlobalScope */
Expand Down Expand Up @@ -12868,6 +12875,9 @@ Change Log</h2>
* <a href="https://github.com/WebAudio/web-audio-api/issues/2361">Issue 2361</a>: Use new Web IDL buffer primitives
<div id="change-list-2361">
</div>
* <a href="https://github.com/WebAudio/web-audio-api/issue/2359">Issue 2359</a>: Fix a typo in the VUMeterNode example
<div id="change-list-2359">
</div>
* <a href="https://github.com/WebAudio/web-audio-api/issues/2373">Issue 2373</a>: Fix a typo: initially instead of initialy
<div id="change-list-2373">
</div>
Expand Down