Fix #2359: Fix typo in VUMeterNode #2360
Conversation
| </span> | ||
| Fix typo in code; semi-colon is incorrect. | ||
| </div> | ||
| <pre line-numbers class="example" highlight="js" title="VUMeterNode - Global Scope (vumeternode.js)"> |
There was a problem hiding this comment.
Needed to change xmp to pre so that the del markup works to show what was deleted.
index.bs
Outdated
| @@ -58,6 +58,7 @@ spec:webidl; type:interface; text:Promise | |||
| <link rel="preload" href="https://www.w3.org/scripts/MathJax/2.7.5/config/TeX-AMS-MML_HTMLorMML.js?rev=2.7.5" as="script"> | |||
| <link rel="preload" href="https://www.w3.org/scripts/MathJax/2.7.5/jax/element/mml/optable/BasicLatin.js?rev=2.7.5" as="script"> | |||
| <link rel="preload" href="https://www.w3.org/scripts/MathJax/2.7.5/jax/output/HTML-CSS/autoload/mtable.js?rev=2.7.5" as="script"> | |||
| <script src="//www.w3.org/scripts/TR/2016/fixup.js" type="application/javascript"></script> | |||
There was a problem hiding this comment.
Is this the right place to get fixup.js?
There was a problem hiding this comment.
Just curious - why do we need fixup.js? Can you point me to the discussion?
|
See also https://github.com/WebAudio/web-audio-api/wiki/UpdatingLivingStandard for the approach I've taken here. We will probably want to discuss that page at the next meeting to see if this is really how we want to do this. |
index.bs
Outdated
| @@ -12969,3 +12976,4 @@ Wei, James (Intel Corporation); | |||
| Weitnauer, Michael (IRT); | |||
| Wilson, Chris (Google,Inc); | |||
| Zergaoui, Mohamed (INNOVIMAX) | |||
|
|
|||
index.bs
Outdated
| @@ -58,6 +58,7 @@ spec:webidl; type:interface; text:Promise | |||
| <link rel="preload" href="https://www.w3.org/scripts/MathJax/2.7.5/config/TeX-AMS-MML_HTMLorMML.js?rev=2.7.5" as="script"> | |||
| <link rel="preload" href="https://www.w3.org/scripts/MathJax/2.7.5/jax/element/mml/optable/BasicLatin.js?rev=2.7.5" as="script"> | |||
| <link rel="preload" href="https://www.w3.org/scripts/MathJax/2.7.5/jax/output/HTML-CSS/autoload/mtable.js?rev=2.7.5" as="script"> | |||
| <script src="//www.w3.org/scripts/TR/2016/fixup.js" type="application/javascript"></script> | |||
There was a problem hiding this comment.
Just curious - why do we need fixup.js? Can you point me to the discussion?
|
fixup.js was needed because that's how the candidate corrections/additions are styled. However, I just found out that we don't need to include this anymore; bikeshed automatically adds this now. |
|
"get a reference to the buffer source" appears to be gone. I'll have to figure out what happened between yesterday and today, but I can reproduce this locally and I had updated bikeshed just a bit before. |
|
These candidate corrections should all be listed in a new "Changes since the Recommendation of 17 June 2021" section, which also makes it easy to find them. (This is a general comment, nt a blocker on this specific fix) |
The typo is marked as a candidate correction, and linked to WebAudio#2359 for easy tracking. The id is "c2359" where "c" stands for "correction", and "2359" is the corresponding V1 issue number. This makes it easy to create unique ids for the links necessary for the correction.
* Bikeshed seems to include fixup.js now, so we don't need to do it ourselves. * Remove unneeded blank line
padenot
force-pushed
the
2359-fix-typo-vumeter-example
branch
from
cd5d1b0 to
0e1565b
Compare
|
I've added the bits @svgeesus talks about, this is good for merging. |
The typo is marked as a candidate correction, and linked to #2359 for
easy tracking. The id is "c2359" where "c" stands for "correction",
and "2359" is the corresponding V1 issue number. This makes it easy
to create unique ids for the links necessary for the correction.
Preview | Diff