Remove exact nan-pattern tests #381
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM, but @sunfishcode should sign off as well. |
|
@sunfishcode Could you please take a look? |
|
lgtm. As I commented in #286, these are important cases to cover, but for now we lack a way to effectively test them. |
|
@bnjbvr Did we test these using the magic test mode so that the engine spits out the literal bit contents? |
|
@lukewagner Yes indeed; any spec test that uses equality with a precise NaN pattern checks against that same pattern spit out as a literal integer. All the spec tests are run under the magic test mode, in Spidermonkey CI. |
ngzhian
pushed a commit
to ngzhian/spec
that referenced
this pull request
Nov 4, 2021
ngzhian
added a commit
to ngzhian/spec
that referenced
this pull request
Nov 4, 2021
These instructions were added in WebAssembly#381 and WebAssembly#411 respectively. The binary opcodes for these are still not finalized, I'm using what V8 is using for now.
raoxiaojia
pushed a commit
to WasmCert/spec
that referenced
this pull request
Apr 29, 2025
Exact nan-pattern tests got obsolete with WebAssembly/design#716 (WebAssembly#381)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes exact some remaining exact nan-pattern tests because they became obsolete in WebAssembly/design#716. Similar tests without bit pattern matching exist in f32.wast and f64.wast.