Multi-Memories improvements to binaryen-c.cpp #4940
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was
linked to
issues
Aug 19, 2022
tlively
approved these changes
Aug 19, 2022
src/binaryen-c.cpp
Outdated
| static Name getMemoryName(BinaryenModuleRef module, const char* memName) { | ||
| const char* memoryName = memName; | ||
| if (memName == nullptr && module->memories.size() == 1) { | ||
| memoryName = module->memories[0]->name.c_str(); |
There was a problem hiding this comment.
We can save some unnecessary conversions between char* and Name here.
Suggested change
| memoryName = module->memories[0]->name.c_str(); | |
| return module->memories[0]->name; |
kripken
approved these changes
Aug 19, 2022
src/binaryen-c.cpp
Outdated
Comment on lines
1076
to
1078
| static Name getMemoryName(BinaryenModuleRef module, const char* memName) { | ||
| const char* memoryName = memName; | ||
| if (memName == nullptr && module->memories.size() == 1) { |
There was a problem hiding this comment.
Suggested change
| static Name getMemoryName(BinaryenModuleRef module, const char* memName) { | |
| const char* memoryName = memName; | |
| if (memName == nullptr && module->memories.size() == 1) { | |
| static Name getMemoryName(BinaryenModuleRef module, const char* memoryName) { | |
| if (memoryName == nullptr && module->memories.size() == 1) { |
The parameter can be reused.
|
I tried Binaryen with this API update. Unfortunately if you set 0 (nullptr) for memoryName for BinaryenLoad / BinaryenStore then Binaryen crashes with assert error here: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolving a couple of issues from the multi-memories PR landing:
memNameas parameter label instead ofname#4916Note: CI will not pass until #4939 lands.