Fixing print-profile.wast test #4939
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tlively
approved these changes
Aug 19, 2022
There was a problem hiding this comment.
I’m surprised this works without giving the memory a name. A name (or at least index) on the export statement would say which memory is being exported. Maybe one of the 0s in the export declaration is being interpreted as an index? In that case, the other 0 seems like it shouldn’t be there.
But anyway lgtm to fix CI. Parser issues will eventually be resolved by switching to the new parser.
kripken
approved these changes
Aug 19, 2022
|
@tlively - good points, it seems like something is wrong in the s-parser logic there... the export declaration should only take a name or an index, and error on having an extra param. |
|
Landing this to unbreak CI and PRs. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In a multi-memories world, memory must be explicitly defined before being exported. Fix CI for 6b3f3af.
/cc @sps-gold