Handle indirect calls in CallGraphPropertyAnalysis #2624
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tlively
approved these changes
Jan 24, 2020
| @@ -549,7 +549,8 @@ class ModuleAnalyzer { | |||
| return !info.isBottomMostRuntime && | |||
| !info.inBlacklist; | |||
| }, | |||
| [](Info& info) { info.canChangeState = true; }); | |||
| [](Info& info) { info.canChangeState = true; }, | |||
| scanner.IgnoreIndirectCalls); | |||
There was a problem hiding this comment.
It seems strange to use scanner in the path to IgnoreIndirectCalls, but I guess the enclosing type is a pain to type out, so this is fine.
There was a problem hiding this comment.
Yeah, this seemed shorter, but I'm not totally happy with it either. Another option might be get_type_or_whatsitcalled(scanner)::IgnoreIndirectCalls?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We ignored them, which is a bad default, as typically they imply
we can call anything in the table (and the table might change).
Instead, notice indirect calls during traversal, and force the user
to decide whether to ignore them or not.
This was only an issue in PostEmscripten because the other
user, Asyncify, already had indirect call analysis because it
needed it for other things.
Fixes a bug uncovered by #2619 and fixes the current binaryen
roll.