Remove s2wasm #1607
Remove s2wasm #1607
Conversation
|
Probably worth holding off landing this for a week or two.. |
kripken
left a comment
kripken
left a comment
There was a problem hiding this comment.
Great!
Btw, are the docs here still up to date? http://kripken.github.io/emscripten-site/docs/compiling/WebAssembly.html#llvm-webassembly-backend
| * **wasm-opt**: Loads WebAssembly and runs Binaryen IR passes on it. | ||
| * **asm2wasm**: An asm.js-to-WebAssembly compiler, using Emscripten's asm optimizer infrastructure. This is used by Emscripten in Binaryen mode when it uses Emscripten's fastcomp asm.js backend. | ||
| * **wasm2asm**: A WebAssembly-to-asm.js compiler (still experimental). | ||
| * **s2wasm**: A compiler from the `.s` format emitted by the new WebAssembly backend being developed in LLVM. This is used by Emscripten in Binaryen mode when it integrates with the new LLVM backend. |
There was a problem hiding this comment.
while we update this list, maybe worth adding wasm-emscripten-finalize and wasm-link-metadata?
| return false; | ||
| } | ||
|
|
||
| inline void exportFunction(Module& wasm, Name name, bool must_export) { |
jgravelle-google
left a comment
jgravelle-google
left a comment
There was a problem hiding this comment.
Goodness that's nice
CI failure says there's still an S2WASM in shared.py. grep -ir s2wasm to see if there's any more?
|
Also removed all the .s files! |
s2wasm is no longer used my emscripten and as far as I know now as no other users.
|
Is there a recommended alternative to s2wasm? I was using this for my own pipeline rather than using emscripten. Is there a new recommended build toolchian for folks who don't or can't depend on emscripten? |
|
Upstream LLVM + LLD, which is what emscripten is using now. |
|
Don't mean to resurrect this issue or anything, but if you, like me, happen across this in a search to find a replacement to s2wasm then you'd better get familiar with wasm-ld. Check out The |
s2wasm is no longer used my emscripten and as far as I know now
as no other users.