A bit smarter s2wasm. #1306
Closed
A bit smarter s2wasm. #1306
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dschuff
reviewed
Nov 27, 2017
Member
dschuff
left a comment
dschuff
left a comment
There was a problem hiding this comment.
Thanks for the patch! It looks like this change handles escaped strings in several places, as well as braces in separated lists. It should have a test (you can add a file in tests/s2wasm) that covers those cases. Also please make the PR description more specific (you can just add one as a comment, we can copy/paste when we merge).
| *strchr(temp, '@') = 0; | ||
| static const char* bads = "\";<>() "; | ||
| static const char* goods = "\'$__$$$"; | ||
| int index = 0; |
| while (*s && !isspace(*s)) { | ||
| str += *s; | ||
| s++; | ||
| if (*s == '\"') { |
Member
There was a problem hiding this comment.
This if-block is repeated 3 times here and below; can we factor it into a function? Any other common code from those uses that can also be factored out?
Contributor
|
I think this PR can be closed since #1607 s2wasm has been removed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a patch we need in Kotlin/Native for the
s2wasmto understand more advanced asm.