Skip to content

Conversation

@d33bs
Copy link
Member

@d33bs d33bs commented Apr 20, 2025

Description

When using pull_request_target and attempting to use downstream (e.g. forked) repository branches one must specify the checkout repository branch manually in order for it to run as expected. Otherwise, checkouts will always be against the target (e.g. main), invalidating the point of running the GH Actions tests to begin with. This PR changes that setting and will allow this to be fixed moving forward. References #34, where this currently is exhibited (the changes to the forked branch do not fix the GH Actions runs).

What kind of change(s) are included?

  • Documentation (changes docs or other related content)
  • Bug fix (fixes an issue).
  • Enhancement (adds functionality).
  • Breaking change (these changes would cause existing functionality to not work as expected).

Checklist

Please ensure that all boxes are checked before indicating that this pull request is ready for review.

  • I have read and followed the CONTRIBUTING.md guidelines.
  • I have searched for existing content to ensure this is not a duplicate.
  • I have performed a self-review of these additions (including spelling, grammar, and related).
  • These changes pass all pre-commit checks.
  • I have added comments to my code to help provide understanding
  • I have added a test which covers the code changes found within this PR
  • I have deleted all non-relevant text in this pull request template.

@d33bs d33bs marked this pull request as ready for review April 21, 2025 15:53
@d33bs d33bs mentioned this pull request Apr 25, 2025
11 tasks
@d33bs
Copy link
Member Author

d33bs commented Apr 25, 2025

Thanks @gwaybio ! Merging this in.

@d33bs d33bs merged commit a938216 into WayScience:main Apr 25, 2025
3 of 5 checks passed
@d33bs d33bs deleted the upstream-gh-actions branch April 25, 2025 20:57
MikeLippincott pushed a commit to MikeLippincott/nViz that referenced this pull request Sep 29, 2025
…ce#35)

* enable downstream branches to be checked out

* Update .pre-commit-config.yaml

* linting
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants