Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bower Installs from v0.3.0-wip Branch, Which is IE8 Incompatible #69

Closed
dubilla opened this issue Jul 8, 2014 · 3 comments
Closed

Bower Installs from v0.3.0-wip Branch, Which is IE8 Incompatible #69

dubilla opened this issue Jul 8, 2014 · 3 comments

Comments

@dubilla
Copy link

dubilla commented Jul 8, 2014

It looks like Bower is pointing to the v0.3.0-wip branch, which currently contains an IE8 bug in https://github.com/Waxolunist/bootstrap3-wysihtml5-bower/blob/v0.3.0-wip/dist/bootstrap3-wysihtml5.all.min.js. I expect Bower to install from the master branch. Is that not the case?

For what it's worth (and I'm not sure if it's worth filing), the IE8 bug in question is here: https://github.com/Waxolunist/bootstrap3-wysihtml5-bower/blob/v0.3.0-wip/dist/bootstrap3-wysihtml5.all.js#L6242

delete attributes.class;

Which throws an error in IE8 because the browser does not handle the attribute of .class well.

@Waxolunist
Copy link
Owner

The 0.3-branch is actually using this repo: https://github.com/edicy/wysihtml5
So the bug is in this repo.
Bower should use the latest tag which is currently 0.3.2.
Only in the tags the dist files are updated which are built from the 0.3.0-wip branch.
The master branch is the current legacy branch for all 0.2.x releases.
The difference is the underlying editor.
0.3.x is based upon https://github.com/edicy/wysihtml5 whereas the versions 0.2.x use the not maintained editor from here https://github.com/xing/wysihtml5

@Waxolunist Waxolunist added the bug label Jul 9, 2014
@Waxolunist Waxolunist added this to the v0.3.3 (current development) milestone Jul 9, 2014
@Waxolunist Waxolunist self-assigned this Jul 9, 2014
@Waxolunist Waxolunist modified the milestones: 0.3.4, v0.3.3 (current development) Sep 8, 2014
@Waxolunist
Copy link
Owner

Needs IE8 test environment.

@Waxolunist
Copy link
Owner

The development of bootstrap3-wysiwyg will be continued in a new repo: https://github.com/bootstrap-wysiwyg/bootstrap3-wysiwyg
@schnawel007 and @Waxolunist are bundling development forces for an even better editor.
This issue will be continued here: bootstrap-wysiwyg/bootstrap3-wysiwyg#69

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants