Bower Installs from v0.3.0-wip Branch, Which is IE8 Incompatible

[Waxolunist]

Issue by dubilla
Tuesday Jul 08, 2014 at 15:47 GMT
Originally opened as Waxolunist/bootstrap3-wysihtml5-bower#69

---

It looks like Bower is pointing to the v0.3.0-wip branch, which currently contains an IE8 bug in https://github.com/Waxolunist/bootstrap3-wysihtml5-bower/blob/v0.3.0-wip/dist/bootstrap3-wysihtml5.all.min.js. I expect Bower to install from the master branch. Is that not the case?

For what it's worth (and I'm not sure if it's worth filing), the IE8 bug in question is here: https://github.com/Waxolunist/bootstrap3-wysihtml5-bower/blob/v0.3.0-wip/dist/bootstrap3-wysihtml5.all.js#L6242

delete attributes.class;

Which throws an error in IE8 because the browser does not handle the attribute of .class well.

[Waxolunist]

Comment by Waxolunist
Wednesday Jul 09, 2014 at 06:22 GMT

---

The 0.3-branch is actually using this repo: https://github.com/edicy/wysihtml5
So the bug is in this repo.
Bower should use the latest tag which is currently 0.3.2.
Only in the tags the dist files are updated which are built from the 0.3.0-wip branch.
The master branch is the current legacy branch for all 0.2.x releases.
The difference is the underlying editor.
0.3.x is based upon https://github.com/edicy/wysihtml5 whereas the versions 0.2.x use the not maintained editor from here https://github.com/xing/wysihtml5

[Waxolunist]

Comment by Waxolunist
Monday Sep 08, 2014 at 06:54 GMT

---

Needs IE8 test environment.

[hcarvalhoalves]

The problem is that bootstrap3-wysihtml5.all.js is including an outdated version of wysihtml5 with the IE8 bug. I fixed by using the stand-alone file and including the dependencies (wyshtml5x.js, handlebars.runtime.js, etc) myself.