-
Notifications
You must be signed in to change notification settings - Fork 260
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Latest Update Throws IE8 Error #92
Comments
Hi, Better to report that here: https://github.com/Waxolunist/bootstrap3-wysihtml5-bower |
Thanks, @Nerian. I thought that was the source of the JS, but I couldn't find that code in the https://github.com/Waxolunist/bootstrap3-wysihtml5-bower/blob/master/src/bootstrap3-wysihtml5.js repo. Where in that repo are you pulling the JS from? Thanks! |
That's the right repo :) The js file that this project packages is this: I don't see any You can take a look at this file to see where each file in tis gem comes from: |
Ah, I see. It's installing via bower and then moving the JS file via the copy_javascript method in the Rakefile. It seems like https://github.com/Nerian/bootstrap-wysihtml5-rails/blob/master/vendor/assets/javascripts/bootstrap-wysihtml5/bootstrap3-wysihtml5.js should then be the same as https://github.com/Waxolunist/bootstrap3-wysihtml5-bower/blob/master/dist/bootstrap3-wysihtml5.all.min.js, but it's not. I'll do some more digging. Maybe I'd have more luck if I bring this repo down and run the Rakefile myself. Thanks for all of the help! |
Sorry the link was wrong. It's the branch v0.3.0-wip. That file includes 'delete l.class' |
Thanks! I'm surprised that bower installs from the branch instead of master. Regardless, I filed a bug here: Waxolunist/bootstrap3-wysihtml5-bower#69 Thanks again for all of the help. |
BTW you can install with bower from every tag or branch but I recommend using a release tag. |
We upgraded to the latest version, 0.3.2.100, and an error is being thrown in IE8. IE8 throws an error on a line being used in the latest bootstrap3-wysihtml5.js.
I'm trying to find out where this JS is originating from, so I can better understand what repo this issue belongs to. Any guidance would be appreciated. Thanks!
The text was updated successfully, but these errors were encountered: