Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Latest Update Throws IE8 Error #92

Closed
dubilla opened this issue Jul 7, 2014 · 7 comments
Closed

Latest Update Throws IE8 Error #92

dubilla opened this issue Jul 7, 2014 · 7 comments

Comments

@dubilla
Copy link

dubilla commented Jul 7, 2014

We upgraded to the latest version, 0.3.2.100, and an error is being thrown in IE8. IE8 throws an error on a line being used in the latest bootstrap3-wysihtml5.js.

delete l.class

I'm trying to find out where this JS is originating from, so I can better understand what repo this issue belongs to. Any guidance would be appreciated. Thanks!

@Nerian
Copy link
Owner

Nerian commented Jul 8, 2014

Hi,

Better to report that here: https://github.com/Waxolunist/bootstrap3-wysihtml5-bower

@dubilla
Copy link
Author

dubilla commented Jul 8, 2014

Thanks, @Nerian. I thought that was the source of the JS, but I couldn't find that code in the https://github.com/Waxolunist/bootstrap3-wysihtml5-bower/blob/master/src/bootstrap3-wysihtml5.js repo. Where in that repo are you pulling the JS from? Thanks!

@Nerian
Copy link
Owner

Nerian commented Jul 8, 2014

That's the right repo :)

The js file that this project packages is this:
https://github.com/Waxolunist/bootstrap3-wysihtml5-bower/blob/master/dist/bootstrap3-wysihtml5.all.min.js

I don't see any delete l.class in that file though.

You can take a look at this file to see where each file in tis gem comes from:
https://github.com/Nerian/bootstrap-wysihtml5-rails/blob/master/Rakefile#L27

@dubilla
Copy link
Author

dubilla commented Jul 8, 2014

Ah, I see. It's installing via bower and then moving the JS file via the copy_javascript method in the Rakefile. It seems like https://github.com/Nerian/bootstrap-wysihtml5-rails/blob/master/vendor/assets/javascripts/bootstrap-wysihtml5/bootstrap3-wysihtml5.js should then be the same as https://github.com/Waxolunist/bootstrap3-wysihtml5-bower/blob/master/dist/bootstrap3-wysihtml5.all.min.js, but it's not.

I'll do some more digging. Maybe I'd have more luck if I bring this repo down and run the Rakefile myself. Thanks for all of the help!

@Nerian
Copy link
Owner

Nerian commented Jul 8, 2014

Sorry the link was wrong. It's the branch v0.3.0-wip.

https://github.com/Waxolunist/bootstrap3-wysihtml5-bower/blob/v0.3.0-wip/dist/bootstrap3-wysihtml5.all.min.js

That file includes 'delete l.class'

@dubilla
Copy link
Author

dubilla commented Jul 8, 2014

Thanks! I'm surprised that bower installs from the branch instead of master. Regardless, I filed a bug here: Waxolunist/bootstrap3-wysihtml5-bower#69

Thanks again for all of the help.

@Nerian Nerian closed this as completed Jul 8, 2014
@Waxolunist
Copy link

BTW you can install with bower from every tag or branch but I recommend using a release tag.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants