Repository navigation
v2 spec: the pre-init refusal (precision) and chs_preview_row reads exactly one row (prose, fp unchanged) - #622
Merged
Merged
Conversation
…after chs_shutdown A precision fix to #621's Teardown sentence, before the producer pins it: chs_shutdown returns void, so it was never among the chs_status calls the sentence excepted, and after chs_shutdown has run every such call refuses the same way (CHS_INVALID_ARGUMENT, code 0, a message saying chs_shutdown has run). Prose only; the fingerprint is unchanged. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
…e row The producer's requirement, stated in the spec before its next library build: chs_preview_row reads all of body with chs_preview_batch's reader; a malformed tail or trailing content the reader does not skip is rejected with the reader's own code, as a server's INSERT rejects it; zero rows or more than one is CHS_INVALID_ARGUMENT naming the call (chs_preview_batch answers many rows); and the row document equals the single row of chs_preview_batch's document for the same body. Both statuses are already in may_return, so the fingerprint is unchanged; prose only. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
EricAndrechek
added a commit
that referenced
this pull request
Oct 11, 2026
The next dev release: a declined export's payload is absent in all four bindings, decided from export_declined (#620); the v2 spec states NULL out_export on a declined export, the pre-init and post-shutdown refusals, and chs_preview_row's exactly-one-row rule (#621, #622; prose, the fingerprint is unchanged); the filter enforcement gate lifted again for 11 pairs and a CREATE-level divergence registered (#617); a test-timing fix and failure text in the stub census (#618). It pairs with artifact build 20261011.105019 at fingerprint d60a681e. The same eight files as the 2.0.0-dev.7 bump. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two prose statements in the v2 spec, made before the artifact producer pins the header:
chs_initializealone (chs_shutdownreturns void, so it was never among thechs_statuscalls); and afterchs_shutdownhas run, every such call refuses the same way (CHS_INVALID_ARGUMENT, ClickHouse code 0, a message sayingchs_shutdownhas run).chs_preview_rowreads the whole body, which holds exactly one row (the producer's requirement for its next library build): the body is read withchs_preview_batch's reader; a malformed tail or trailing content the reader does not skip is rejected with the reader's own code, as a server's INSERT rejects it, while what the reader skips (a trailing newline) is fine; zero rows or more than one isCHS_INVALID_ARGUMENT, naming the call, withchs_preview_batchthe call for many rows; and the row document equals the single row ofchs_preview_batch's document for the same body. Published builds up to and including20261011.105019answer from the first row and ignore the rest.Prose only (
spec/abi-v2/docs.md, regeneratedinclude/v2/chtypes.handdocs/reference/abi-v2.md). Both statuses are already inchs_preview_row'smay_return. Measured:gen.py --major 2 --checkpasses, the fingerprint is unchanged (d60a681e…), and the header sha256 isb2d9b8290ffc311a57f91998495ae0588a0f93eeb6bb8b3efc5efb549f089315. markdownlint, dprint,lint-spelling,lint-cited-pathsandlint-publicpass.🤖 Generated with Claude Code