fix: Don't compile docs if there is no need #3503
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
majk-p
approved these changes
Feb 17, 2025
ghostbuster91
commented
Feb 17, 2025
modules/cli/src/main/scala/scala/cli/commands/publish/SharedPublishOptions.scala
Show resolved
Hide resolved
Gedochao
reviewed
Feb 18, 2025
There was a problem hiding this comment.
Hey, thanks for the contribution!
Perhaps we could add a test for the --doc=false case?
Perhaps somewhere here: https://github.com/VirtusLab/scala-cli/blob/d2bd538f28994b1bd540f14b5a2e7057ae598411/modules/integration/src/test/scala/scala/cli/integration/PublishLocalTestDefinitions.scala
modules/cli/src/main/scala/scala/cli/commands/publish/SharedPublishOptions.scala
Show resolved
Hide resolved
Mee-Tree
pushed a commit
to Mee-Tree/scala-cli
that referenced
this pull request
Mar 21, 2025
* fix: Don't compile docs if there is no need * Add testcase for publishing without docs --------- Co-authored-by: ghostbuster91 <ghostbuster91@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a little optimization to the publish commands.
If
doc=falseis passed it doesn't even attempt to compile javadocs which speeds up the whole process.This is important in cases where people use bloop for compilation as javadocs compilation does not use bloop which results in effectively compiling everything twice.