fix: Don't compile docs if there is no need (#3503)

* fix: Don't compile docs if there is no need

* Add testcase for publishing without docs

---------

Co-authored-by: ghostbuster91 <ghostbuster91@users.noreply.github.com>

Author: ghostbuster91

modules/cli/src/main/scala/scala/cli/commands/publish/Publish.scala

@@ -230,8 +230,8 @@ object Publish extends ScalaCommand[PublishOptions] with BuildCommandHelpers {
     ).orExit(logger)
     val threads = BuildThreads.create()
 
-    val compilerMaker    = options.shared.compilerMaker(threads)
-    val docCompilerMaker = options.shared.compilerMaker(threads, scaladoc = true)
+    val compilerMaker       = options.shared.compilerMaker(threads)
+    val docCompilerMakerOpt = options.sharedPublish.docCompilerMakerOpt
 
     val cross = options.compileCross.cross.getOrElse(false)
 
@@ -256,7 +256,7 @@ object Publish extends ScalaCommand[PublishOptions] with BuildCommandHelpers {
       logger,
       initialBuildOptions,
       compilerMaker,
-      docCompilerMaker,
+      docCompilerMakerOpt,
       cross,
       workingDir,
       ivy2HomeOpt,
@@ -278,7 +278,7 @@ object Publish extends ScalaCommand[PublishOptions] with BuildCommandHelpers {
     logger: Logger,
     initialBuildOptions: BuildOptions,
     compilerMaker: ScalaCompilerMaker,
-    docCompilerMaker: ScalaCompilerMaker,
+    docCompilerMaker: Option[ScalaCompilerMaker],
     cross: Boolean,
     workingDir: => os.Path,
     ivy2HomeOpt: Option[os.Path],
@@ -299,7 +299,7 @@ object Publish extends ScalaCommand[PublishOptions] with BuildCommandHelpers {
         inputs,
         initialBuildOptions,
         compilerMaker,
-        Some(docCompilerMaker),
+        docCompilerMaker,
         logger,
         crossBuilds = cross,
         buildTests = false,
@@ -333,7 +333,7 @@ object Publish extends ScalaCommand[PublishOptions] with BuildCommandHelpers {
           inputs,
           initialBuildOptions,
           compilerMaker,
-          Some(docCompilerMaker),
+          docCompilerMaker,
           logger,
           crossBuilds = cross,
           buildTests = false,

modules/cli/src/main/scala/scala/cli/commands/publish/PublishLocal.scala

@@ -51,8 +51,8 @@ object PublishLocal extends ScalaCommand[PublishLocalOptions] {
     ).orExit(logger)
     val threads = BuildThreads.create()
 
-    val compilerMaker    = options.shared.compilerMaker(threads)
-    val docCompilerMaker = options.shared.compilerMaker(threads, scaladoc = true)
+    val compilerMaker       = options.shared.compilerMaker(threads)
+    val docCompilerMakerOpt = options.sharedPublish.docCompilerMakerOpt
 
     val cross = options.compileCross.cross.getOrElse(false)
 
@@ -75,7 +75,7 @@ object PublishLocal extends ScalaCommand[PublishLocalOptions] {
       logger,
       initialBuildOptions,
       compilerMaker,
-      docCompilerMaker,
+      docCompilerMakerOpt,
       cross,
       workingDir,
       ivy2HomeOpt,

modules/cli/src/main/scala/scala/cli/commands/publish/SharedPublishOptions.scala

@@ -2,6 +2,7 @@ package scala.cli.commands.publish
 
 import caseapp.*
 
+import scala.build.compiler.{ScalaCompilerMaker, SimpleScalaCompilerMaker}
 import scala.cli.commands.shared.HelpGroup
 import scala.cli.commands.tags
 
@@ -85,8 +86,15 @@ final case class SharedPublishOptions(
   @HelpMessage("Proceed as if publishing, but do not upload / write artifacts to the remote repository")
   @Tag(tags.implementation)
     dummy: Boolean = false
-)
-// format: on
+){
+  // format: on
+
+  def docCompilerMakerOpt: Option[ScalaCompilerMaker] =
+    if (doc.contains(false)) // true by default
+      None
+    else
+      Some(SimpleScalaCompilerMaker("java", Nil, scaladoc = true))
+}
 
 object SharedPublishOptions {
   implicit lazy val parser: Parser[SharedPublishOptions] = Parser.derive

modules/integration/src/test/scala/scala/cli/integration/PublishLocalTestDefinitions.scala

@@ -258,4 +258,52 @@ abstract class PublishLocalTestDefinitions extends ScalaCliSuite with TestScalaV
       }
     }
 
+    test("publish local without docs") {
+      val expectedFiles = {
+        val modName = s"${PublishTestInputs.testName}_$testedPublishedScalaVersion"
+        val base    = os.rel / PublishTestInputs.testOrg / modName / testPublishVersion
+        val baseFiles = Seq(
+          base / "jars" / s"$modName.jar",
+          base / "srcs" / s"$modName-sources.jar",
+          base / "poms" / s"$modName.pom",
+          base / "ivys" / "ivy.xml"
+        )
+        baseFiles
+          .flatMap { f =>
+            val md5  = f / os.up / s"${f.last}.md5"
+            val sha1 = f / os.up / s"${f.last}.sha1"
+            Seq(f, md5, sha1)
+          }
+          .toSet
+      }
+
+      PublishTestInputs.inputs()
+        .fromRoot { root =>
+          os.proc(
+            TestUtil.cli,
+            "--power",
+            "publish",
+            "local",
+            ".",
+            "--ivy2-home",
+            os.rel / "ivy2",
+            extraOptions,
+            "--doc=false"
+          )
+            .call(cwd = root)
+          val ivy2Local = root / "ivy2" / "local"
+          val foundFiles = os.walk(ivy2Local)
+            .filter(os.isFile(_))
+            .map(_.relativeTo(ivy2Local))
+            .toSet
+          val missingFiles    = expectedFiles -- foundFiles
+          val unexpectedFiles = foundFiles -- expectedFiles
+          if (missingFiles.nonEmpty)
+            pprint.err.log(missingFiles)
+          if (unexpectedFiles.nonEmpty)
+            pprint.err.log(unexpectedFiles)
+          expect(missingFiles.isEmpty)
+          expect(unexpectedFiles.isEmpty)
+        }
+    }
 }