test: fix skinned vertex stub for test #37
Merged
+23
−6
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Greptile Overview
Greptile Summary
This PR corrects the test stub and test data for vertex influences to match the actual W3D format specification.
Key changes:
SkinnedVertexstruct to test stub (tests/stubs/core/pipeline.hpp) with the requiredcstdintinclude foruint32_ttypeVertexInfluencesParsingtest to use the correct W3D format: 8 bytes per vertex influence (uint16 BoneIdx + 6 bytes padding) instead of 2 bytesweightfield (which is set to1.0ffor rigid skinning) instead of the incorrectboneIndex2fieldThe changes align the test with the production implementation in
src/w3d/mesh_parser.cpp:76-89, which correctly parses the 8-byte W3dVertInfStruct format used in legacy W3D files.Confidence Score: 5/5
mesh_parser.cpp. The stub addition is minimal and necessary.Important Files Changed
SkinnedVertexstruct andcstdintinclude to stub for test support