Skip to content

Conversation

@ViTeXFTW
Copy link
Owner

@ViTeXFTW ViTeXFTW commented Jan 29, 2026

Greptile Overview

Greptile Summary

This PR corrects the test stub and test data for vertex influences to match the actual W3D format specification.

Key changes:

  • Added SkinnedVertex struct to test stub (tests/stubs/core/pipeline.hpp) with the required cstdint include for uint32_t type
  • Fixed VertexInfluencesParsing test to use the correct W3D format: 8 bytes per vertex influence (uint16 BoneIdx + 6 bytes padding) instead of 2 bytes
  • Updated test assertions to validate weight field (which is set to 1.0f for rigid skinning) instead of the incorrect boneIndex2 field

The changes align the test with the production implementation in src/w3d/mesh_parser.cpp:76-89, which correctly parses the 8-byte W3dVertInfStruct format used in legacy W3D files.

Confidence Score: 5/5

  • This PR is safe to merge - it fixes test code to match the correct W3D format specification
  • The changes are straightforward test fixes with no impact on production code. The test data format now correctly matches the W3D specification (8 bytes per vertex influence) and the implementation in mesh_parser.cpp. The stub addition is minimal and necessary.
  • No files require special attention

Important Files Changed

Filename Overview
tests/stubs/core/pipeline.hpp Added SkinnedVertex struct and cstdint include to stub for test support
tests/w3d/test_mesh_parser.cpp Fixed test data format to match W3D spec (8 bytes per vertex influence) and corrected assertions

Copy link

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

2 files reviewed, no comments

Edit Code Review Agent Settings | Greptile

@ViTeXFTW ViTeXFTW merged commit 26bc80a into dev Jan 29, 2026
@ViTeXFTW ViTeXFTW deleted the claude/rebase-and-cleanup-eyZfx branch January 30, 2026 06:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants