Skip to content

Conversation

@ViTeXFTW
Copy link
Owner

@ViTeXFTW ViTeXFTW commented Jan 29, 2026

Greptile Overview

Greptile Summary

Added missing SkinnedVertex stub to test pipeline header, fixing test compilation. Also implemented comprehensive hover detection system with raycasting for meshes, bones, and joints, including UI tooltips and visual highlighting. Additional improvements include build optimization flags and more reliable shader embedding via file-based approach.

Confidence Score: 5/5

  • This PR is safe to merge with no critical issues found
  • The changes are well-tested with comprehensive raycast tests, follow established patterns, and properly handle edge cases. The main fix (missing SkinnedVertex stub) is straightforward and necessary for test compilation.
  • No files require special attention

Important Files Changed

Filename Overview
tests/stubs/core/pipeline.hpp Added missing SkinnedVertex stub for tests
src/render/raycast.cpp Implemented raycasting functions using Möller-Trumbore and geometric algorithms
src/render/hover_detector.cpp Implemented hover detection with priority for skeleton over meshes
src/main.cpp Integrated hover detection with UI tooltip and rendering pipeline
tests/w3d/test_mesh_parser.cpp Fixed vertex influences test to match W3D format (8 bytes per vertex)

Copy link

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

5 files reviewed, no comments

Edit Code Review Agent Settings | Greptile

@ViTeXFTW
Copy link
Owner Author

Closed in favor of #37

@ViTeXFTW ViTeXFTW closed this Jan 29, 2026
@ViTeXFTW ViTeXFTW deleted the fix/test-stub-skinned-vertex branch January 30, 2026 06:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants