[PATCH] Fix parsing submodule URL (passes tests) #7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update validation CI
…tlab-submodule into fix-url-parsing
ValentinFrancois
force-pushed
the
main
branch
2 times, most recently
from
717f900 to
3fbaab6
Compare
ValentinFrancois
changed the title
ValentinFrancois
force-pushed
the
main
branch
from
4b7883f to
b3d3dd0
Compare
Contributor
|
Awesome! You code looks good and I tested it in my project without problems. Highly appreciate the addition of more tests! Looks good to me and you can close my other PR when merging this one. |
Owner
Author
|
@darkdragon-001 wonderful, merging now |
Owner
Author
|
Version 0.1.5 released at https://pypi.org/project/python-gitlab-submodule/0.1.5/ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@darkdragon-001 thank you for your contributions, I already merged the 2 small ones.
About parsing the URLs (#3), I thought I had tested the code with some relative submodules, but your PR clearly showed the need of more tests.
So I created https://gitlab.com/python-gitlab-submodule-test/test-projects and I'm now using it for automated tests. This revealed other issues in the parsing logic that should be fixed now.
This PR gathers your original fixes + mine. I also added some more optional args. Feel free to review it and if you agree I'll close the old one.