Fix parsing submodule URL. #3
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ValentinFrancois
force-pushed
the
main
branch
3 times, most recently
from
4b7883f to
b3d3dd0
Compare
Owner
|
Solved by #7, closing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relative URLs should be handled first, only as a fallback we should use
giturlparse. It won't throw and error, for relative paths so thetry/catchwas never used. Also the parsed attributes names changed.Usually we want to iterative over all submodules. In case they are hosted somewhere else, we would still like to access all available properties like submodule path or commit id. I built in a fallback mechanism which could be checked in client code via
subproject.project is None.