Repository navigation
fix(cpp23): shadow identifier + C-style cast cleanup in Wave files (ADR-0839) - #258
Merged
lusoris merged 1 commit intoMay 30, 2026
Merged
Conversation
…DR-0839) Mechanical cleanup in 3 post-C++23-wave cpp files: - fex_ctx_vector.cpp: rename local 'capacity' → 'new_capacity' (shadow fix) - feature_collector.cpp: every (T*) C-style cast → static_cast<T*> - sycl/common.cpp: same C-style → static_cast<> pattern Recreates closed PR #196's 6-file targeted change from current master (the original had cascading rebase conflicts from #197+#212+#256 etc). docs/adr/README.md index row already present on master; skipping that file. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
lusoris
enabled auto-merge (squash)
May 30, 2026 04:16
lusoris
added a commit
that referenced
this pull request
May 30, 2026
…ADR-0840) (#259) Recreates closed PR #199's 6-file targeted change from current master (the original had cascading rebase conflicts from #197+#212+#256+#258). - gpu_dispatch_env.c: TOCTOU window between getenv() and snapshot - vmaf.c: cu_state leak on import failure path Co-authored-by: lusoris <lusoris@pm.me> Co-authored-by: Claude Opus 4.7 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Recreates closed PR #196's 6-file targeted change from current master. Mechanical cleanup; no behaviour change.
no docs needed: internal C++23 conversion TUs only.
Test plan
Deep-dive deliverables (ADR-0108)
## Alternatives considered(in diff)meson test -C build --suite=fastchangelog.d/fixed/cpp23-shadow-const-fixes.md(in diff)docs/rebase-notes.mdupdated (in diff)Lint clean (CLAUDE §12 r12)
State drift (CLAUDE §12 r13)
FFmpeg-patch sync (CLAUDE §12 r14)
🤖 Generated with Claude Code