Repository navigation
fix(corpus): replace hardcoded .corpus/ paths with VMAF_CORPUS_DIR env var - #212
Merged
Merged
Conversation
…v var - ai/scripts/calibrate_nr_threshold.py: _DEFAULT_CORPUS now reads VMAF_CORPUS_DIR env var (falling back to .corpus/netflix), matching the pattern already used by validate_ensemble_seeds.py; adds missing import os. - tools/vmaf-tune/tests/test_bbb_e2e_v5_bug_cluster.py: BBB corpus path reads VMAF_CORPUS_DIR (falling back to /workspace/.corpus/bbb_e2e) instead of a hardcoded /workspace prefix. - .gitignore: add .corpus/ so the exclusion is visible to all contributors (was only in .git/info/exclude). Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
1 of 10 tasks
lusoris
marked this pull request as ready for review
May 30, 2026 02:52
lusoris
enabled auto-merge (squash)
May 30, 2026 02:52
lusoris
added a commit
that referenced
this pull request
May 30, 2026
…DR-0839) (#258) Mechanical cleanup in 3 post-C++23-wave cpp files: - fex_ctx_vector.cpp: rename local 'capacity' → 'new_capacity' (shadow fix) - feature_collector.cpp: every (T*) C-style cast → static_cast<T*> - sycl/common.cpp: same C-style → static_cast<> pattern Recreates closed PR #196's 6-file targeted change from current master (the original had cascading rebase conflicts from #197+#212+#256 etc). docs/adr/README.md index row already present on master; skipping that file. Co-authored-by: lusoris <lusoris@pm.me> Co-authored-by: Claude Opus 4.7 <noreply@anthropic.com>
lusoris
added a commit
that referenced
this pull request
May 30, 2026
…ADR-0840) (#259) Recreates closed PR #199's 6-file targeted change from current master (the original had cascading rebase conflicts from #197+#212+#256+#258). - gpu_dispatch_env.c: TOCTOU window between getenv() and snapshot - vmaf.c: cu_state leak on import failure path Co-authored-by: lusoris <lusoris@pm.me> Co-authored-by: Claude Opus 4.7 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ai/scripts/calibrate_nr_threshold.py:_DEFAULT_CORPUSnow readsVMAF_CORPUS_DIRenv var (fallback.corpus/netflix).tools/vmaf-tune/tests/test_bbb_e2e_v5_bug_cluster.py: BBB corpus readsVMAF_CORPUS_DIR(fallback/workspace/.corpus/bbb_e2e)..gitignore:.corpus/entry added (was only in.git/info/exclude).Supersedes #122 which was contaminated.
no docs needed: internal scripts + test fixtures + .gitignore, no user-discoverable surface.
Test plan
VMAF_CORPUS_DIR=...resolves correctly + falls back to defaultgit check-ignoreresolves .corpus/ from .gitignoreDeep-dive deliverables (ADR-0108)
VMAF_CORPUS_DIR=/my/corpus python ai/scripts/calibrate_nr_threshold.py --dry-runLint clean (CLAUDE §12 r12)
State drift (CLAUDE §12 r13)
FFmpeg-patch sync (CLAUDE §12 r14)
🤖 Generated with Claude Code