Repository navigation
docs(state): reconcile the fork's open Netflix/vmaf pull requests #1631 to #1668 - #2404
Merged
Merged
Conversation
lusoris
force-pushed
the
docs/upstream-reconcile-1631-1668
branch
from
October 7, 2026 11:06
2ca054b to
b9deabe
Compare
…keep the isa flags for icx-cl (#2408) * fix(windows): pass _wsopen_s only the permission bits it accepts and keep the isa flags for icx-cl The first Windows run after #2393 crashed test_path_utf8 and test_output and made the vmaf CLI tests exit 127: _wsopen_s and _sopen_s abort on a permission mode with bits other than _S_IREAD and _S_IWRITE, and the callers pass POSIX modes such as 0644 (_wopen ignored the rest). The mode is masked. The -mavx2 family is withheld from cl.exe only: icx-cl needs it for the intrinsics headers' target-feature check. sycl/common.cpp calls _strdup through VMAF_STRDUP, test_cambi.c casts the last uint16 to uint8 store and replaces CAMBI_TEST_NULL_POINTER with NULL under ADR-1138.
… to #1668 (#2404) * docs(state): reconcile the fork's open Netflix/vmaf pull requests #1631 to #1668 Add a "Confirmed not-affected" row for each of the fork's open upstream pull requests from #1631 to #1668 (25 rows), naming the fork file, test or ADR that shows the fork already carries the fix, covers it another way or is not affected. #1643 is the one open item (a test-only x87 comparison with the same line in the fork). #1634 is recorded as closed: the fork keeps integer AIM unclipped, as upstream defines it. Also records that the ten pull requests that conflicted with upstream master acdd9376e were rebased on 2026-10-07. Documentation only. * docs: regenerate the indexes and the citation map after rebasing
lusoris
force-pushed
the
docs/upstream-reconcile-1631-1668
branch
from
October 7, 2026 13:10
b9deabe to
1e20b61
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Extends the upstream reconciliation in
docs/state.mdfrom #1629 to the fork's remaining open Netflix/vmaf pull requests #1631 to #1668: 25 rows under "Confirmed not-affected", each naming the fork file, test or ADR that shows the fix is already carried, covered another way, or not applicable. #1634 (clip the integer AIM score) is recorded as closed on the maintainer's decision, because the fork keeps integer AIM unclipped (ADR-1417). Documentation only.Type
docs— documentation onlyChecklist
make format && make lintis green locally. (Onlydocs/state.md,CHANGELOG.mdand a changelog fragment changed; the commit hooks ran green with the repo's pinnedpraetorctlbuild,PRAETOR_REF04cc813f.)/cross-backend-diff: no SIMD or GPU code touched.Bug-status hygiene (ADR-0165)
docs/state.mdupdated in this PR with rows under "Confirmed not-affected" and one_Updated:line.Netflix golden-data gate (ADR-0024)
assertAlmostEqual(...)score in the Netflix golden Python tests.Deep-dive deliverables (ADR-0108)
AGENTS.mdinvariant note — no rebase-sensitive invariants.changelog.d/changed/state-upstream-reconcile-1631-1668.md, rendered intoCHANGELOG.mdwithscripts/release/concat-changelog-fragments.sh --write.Reproducer
Known follow-ups
core/test/test_predict.chas the same bare expression as upstream; no fix here.