Repository navigation
fix(sycl): accept bare native images in AOT image check - #1651
Merged
Merged
Conversation
sycl_aot_image_check failed every build configured with one AOT target, such as -Dsycl_icpx_aot_targets=dg2-g11 (the single-target example in docs/backends/sycl/overview.md), with "holds no ocloc fat binary". ocloc writes an image in one of two forms based on the number of device acronyms it was given: - two or more (even sharing one IP): an ar fat binary; - exactly one: a bare zebin, a relocatable ELF with no archive around it. check_aot_image.py now accepts both forms. It reads the GPU IP version of a bare zebin from its .note.intelgt.compat IntelGT product-config note (type 6, HardwareIpVersion word matching 'ocloc ids'), treating it as an image carrying that one IP version so that completeness, --partial, and count rules apply to both forms identically. Closes T-SYCL-AOT-CHECK-REJECTS-SINGLE-TARGET-2026-09-30.
lusoris
force-pushed
the
fix/sycl-aot-check-single-target
branch
from
October 1, 2026 02:03
52b6495 to
588a815
Compare
This was referenced Oct 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
A SYCL build configured with a single AOT target (e.g.
-Dsycl_icpx_aot_targets=dg2-g11, recommended for Arc A380 fleets) failed thesycl_aot_image_checkstep becauseoclocwrites bare ELF native binaries instead ofarfat binaries when given exactly one device acronym. This change updatescore/src/sycl/check_aot_image.pyto accept both forms, extracting the GPU IP version from theHardwareIpVersionIntelGT product-config note (type 6) in.note.intelgt.compat.Type
fix— bug fixsycl/cuda/simd— backend-specificChecklist
make format && make lintis green locally.python3 scripts/ci/run_meson_test.py -- -C build./cross-backend-diffand the worst ULP is ≤ 2..c/.cpp/.cu/.h/.hpp, it has the appropriate license header (seeCONTRIBUTING.md).!orBREAKING CHANGE:and the migration path is documented below.docs/adr/_index_fragments/<NNNN-slug>.mdand the slug is appended todocs/adr/_index_fragments/_order.txt— do not editdocs/adr/README.mddirectly (regenerated byscripts/docs/concat-adr-index.sh; see ADR-0221).Bug-status hygiene (ADR-0165)
docs/state.mdupdated in this PR with a row in the appropriate section (Open / Recently closed / Confirmed not-affected / Deferred), ORno state delta: REASON.Netflix golden-data gate (ADR-0024)
assertAlmostEqual(...)score in the Netflix golden Python tests.Cross-backend numerical results
Deep-dive deliverables (ADR-0108)
AGENTS.mdinvariant note — added to the relevant package'sAGENTS.md, OR "no rebase-sensitive invariants".changelog.d/<section>/<topic>.md(added/changed/deprecated/removed/fixed/security). Do not editCHANGELOG.mddirectly —scripts/release/concat-changelog-fragments.shrenders the Unreleased block from the fragment tree (see ADR-0221).docs/rebase-notes.mdunder a new ID, ORno rebase impact: REASON.Reproducer
Known follow-ups
None.