refactor(lint): GPU slab ptr-cast macro SLAB_FIELD — ADR-0800

.github/workflows/libvmaf-build-matrix.yml

@@ -1105,14 +1105,22 @@ jobs:
         if: matrix.backend == 'cuda'
         shell: cmd
         run: |
+<<<<<<< HEAD
           ninja -v -C core\build install
+=======
+          ninja -v -C libvmaf\build install
+>>>>>>> 24bb5daf89 (docs: post-merge-train sweep — VMAFx + core/ path refs, ADR index, state.md)
 
       - name: Build libvmaf (SYCL)
         if: matrix.backend == 'sycl'
         shell: cmd
         run: |
           call "C:\Program Files (x86)\Intel\oneAPI\setvars.bat"
+<<<<<<< HEAD
           ninja -v -C core\build install
+=======
+          ninja -v -C libvmaf\build install
+>>>>>>> 24bb5daf89 (docs: post-merge-train sweep — VMAFx + core/ path refs, ADR index, state.md)
 
       # No test step — windows-2025 has no GPU. The whole point of
       # this job is exercising the MSVC + CUDA / MSVC + oneAPI link

.github/workflows/security-scans.yml

@@ -133,11 +133,14 @@ jobs:
           languages: python
           queries: security-and-quality
           config-file: ./.github/codeql-config.yml
+<<<<<<< HEAD
       # Python analysis does not require a build step; the explicit no-op
       # below suppresses CodeQL's C++-oriented autobuild.sh which would
       # fail trying to build the old libvmaf/ path (post-rename to core/).
       - name: No-op build (Python analysis only)
         run: echo "Python-only CodeQL scan — no C++ build required"
+=======
+>>>>>>> 24bb5daf89 (docs: post-merge-train sweep — VMAFx + core/ path refs, ADR index, state.md)
       - uses: github/codeql-action/analyze@9e0d7b8d25671d64c341c19c0152d693099fb5ba  # v4
         with:
           category: "/language:python"

.semgrepignore

@@ -7,34 +7,22 @@
 # Netflix-upstream MATLAB MEX helpers. Pure research reference, not linked
 # into libvmaf. The MEX sources use sprintf() in mexErrMsgTxt calls and
 # match our CERT STR31-C guard rule (vmaf-no-strcpy-strcat-sprintf).
-<<<<<<< HEAD
 # Paths updated for ADR-0700 rename (python/vmaf/ → compat/python-vmaf/):
 python/vmaf/matlab/
 compat/python-vmaf/matlab/
-=======
-python/vmaf/matlab/
->>>>>>> 24bb5daf89 (docs: post-merge-train sweep — VMAFx + core/ path refs, ADR index, state.md)
 
 # Netflix-upstream Python training resource tree (datasets, param/feature
 # dicts). Not C/C++; included here for completeness since semgrep's Python
 # rules could fire on the same upstream drift ruff is silenced on.
-<<<<<<< HEAD
 # Paths updated for ADR-0700 rename:
 python/vmaf/resource/
 compat/python-vmaf/resource/
-=======
-python/vmaf/resource/
->>>>>>> 24bb5daf89 (docs: post-merge-train sweep — VMAFx + core/ path refs, ADR index, state.md)
 
 # Standard exclusions — third-party / generated.
 subprojects/
 build/
 dist/
-<<<<<<< HEAD
 core/test/data/
-=======
-libvmaf/test/data/
->>>>>>> 24bb5daf89 (docs: post-merge-train sweep — VMAFx + core/ path refs, ADR index, state.md)
 model/
 testdata/
 
@@ -50,13 +38,9 @@ scripts/git-hooks/pre-push-mkdocs-strict.sh
 # They are tracked in the cJSON project itself; we do not modify this file.
 # Lines: 1660 (FIXME overflow), 2774 (TODO O(n^2)), 2786 (TODO proper fix).
 # (scaffold-audit ADR-0621 P3-6)
-<<<<<<< HEAD
 # Path updated for ADR-0700 rename (libvmaf/ → core/):
 libvmaf/src/mcp/3rdparty/cJSON/cJSON.c
 core/src/mcp/3rdparty/cJSON/cJSON.c
-=======
-libvmaf/src/mcp/3rdparty/cJSON/cJSON.c
->>>>>>> 24bb5daf89 (docs: post-merge-train sweep — VMAFx + core/ path refs, ADR index, state.md)
 
 # Binary / data suffixes.
 *.pkl

AGENTS.md

@@ -364,7 +364,7 @@ linked AGENTS.md before resolving conflicts.
   `libvmaf_mcp.h`, audit-first `-ENOSYS` stubs in
   `core/src/mcp/mcp.c`, `enable_mcp` + 3 transport sub-flags. T5-2b
   (cJSON + mongoose + transport bodies) is open. See
-  [core/AGENTS.md §Rebase-sensitive invariants](core/AGENTS.md).
+  [libvmaf/AGENTS.md §Rebase-sensitive invariants](libvmaf/AGENTS.md).
 - **HIP scaffold (T7-10, ADR-0212 placeholder, PR #200)** —
   audit-first AMD HIP backend scaffold mirroring Vulkan T5-1 /
   ADR-0175. Public `libvmaf_hip.h`, stub kernels, `enable_hip` meson
@@ -380,7 +380,7 @@ linked AGENTS.md before resolving conflicts.
   requires (1) `FEATURE_METRICS` entry, (2) `FEATURE_TOLERANCE` entry
   if it relaxes places=4, (3) row in
   `docs/development/cross-backend-gate.md`. See
-  [core/AGENTS.md](core/AGENTS.md).
+  [libvmaf/AGENTS.md](libvmaf/AGENTS.md).
 - **FastDVDnet temporal pre-filter (T6-7, ADR-0215 placeholder,
   PR #203)** — 5-frame window pre-filter feeding ssim/ms_ssim.
 - **psnr chroma Vulkan (T3-15(b), ADR-0216 placeholder, PR #204)**
@@ -431,22 +431,6 @@ linked AGENTS.md before resolving conflicts.
   `host_id`, `backend_results`, `mcp_results`) are an internal format;
   update `docs/development/dev-mcp.md` if the schema changes. This
   directory does not affect the libvmaf C build or any CI gate.
-- **VMAFX repo-layout rename (`libvmaf/` → `core/`, PR #1571, ADR-0700)**:
-  The C library and build root was renamed from `libvmaf/` to `core/` as
-  part of the VMAFX rebrand (ADR-0686). `libvmaf.so`, `libvmaf.pc`, and
-  `<libvmaf/…>` install-path headers are unchanged. Any in-flight branch
-  that still references paths under `libvmaf/` must be rebased; the
-  recommended recipe is:
-  `git format-patch <base>..<tip> --stdout | sed 's|libvmaf/|core/|g' | git am --3way`
-  The full recipe lives in `docs/rebase-notes.md` §`refactor/meta/vmafx-repo-layout`.
-  Do not introduce new references to `libvmaf/` in any new file.
-- **vmafx-server HTTP transport (`[http]` optional dep, PR #1583, ADR-0701)**:
-  `mcp-server/vmaf-mcp/pyproject.toml` gained an `[http]` optional
-  dependency group (`aiohttp`, `prometheus-client`). Any rebase that
-  modifies `pyproject.toml` must preserve this group. The `--transport http`
-  flag in `server.py::main()` dispatches to `http_transport.py`; do not
-  reorder the transport dispatch block. See
-  [mcp-server/AGENTS.md](mcp-server/AGENTS.md).
 
 ## 14. Interaction style — prefer structured popup questions
 

changelog.d/fixed/0800-gpu-slab-nolint-citations.md

@@ -0,0 +1,6 @@
+- **GPU slab pointer-cast hygiene (ADR-0800)**: introduced `core/src/feature/gpu_slab.h`
+  with the `SLAB_FIELD(dst, type, slab)` macro to centralise the `CUdeviceptr`/`uintptr_t`
+  → typed-pointer cast that all GPU feature-extractor buffer-carving code shares.
+  Replaced 21 bare `performance-no-int-to-ptr` NOLINTs in `integer_vif_hip.c`,
+  `integer_vif_cuda.c`, and `integer_adm_cuda.c` with `SLAB_FIELD` calls — satisfying
+  the ADR-0278 cited-NOLINT rule.  No math change; ADR-0214 GPU-parity gate unaffected.

cmd/vmafx-node/executor_test.go

@@ -1,8 +1,7 @@
 // SPDX-License-Identifier: BSD-3-Clause-Plus-Patent
 // Copyright 2026 Lusoris
 //
-// cmd/vmafx-node/executor_test.go — unit tests for the job executor covering
-// the binary-delegation path (ScoringJob via "false" binary).
+// cmd/vmafx-node/executor_test.go — unit tests for the job executor.
 //
 // ADR-0719: vmafx-node rclone integration.
 package main
@@ -13,15 +12,26 @@ import (
 	"path/filepath"
 	"testing"
 
-	controllerv1 "github.com/VMAFx/vmafx/gen/go/controller"
-	"github.com/VMAFx/vmafx/pkg/libvmaf"
+	"github.com/VMAFx/vmafx/pkg/storage"
 )
 
-// TestExecutor_ScoringJobFailsWithBadBinary verifies that Execute returns a
-// non-nil error when the underlying vmaf binary exits non-zero.
-// We construct a Scorer pointing at "false" (a POSIX built-in that always
-// exits 1) so the unit test never requires a real vmaf installation.
-func TestExecutor_ScoringJobFailsWithBadBinary(t *testing.T) {
+// mockStorage is a Storage that always returns the path it was given.
+type mockStorage struct {
+	mode storage.Mode
+}
+
+func (m *mockStorage) Mode() storage.Mode { return m.mode }
+
+func (m *mockStorage) Prepare(_ context.Context, sourceURI string) (string, func(), error) {
+	return sourceURI, func() {}, nil
+}
+
+// TestExecutor_LocalPaths verifies that the executor calls Prepare on both
+// reference and distorted URIs and forwards the resolved paths to vmaf.
+// The actual vmaf invocation is not run in the unit test; we verify only that
+// Prepare is called and that cleanup is deferred correctly by checking that no
+// goroutines are leaked.
+func TestExecutor_LocalPaths(t *testing.T) {
 	t.Parallel()
 
 	dir := t.TempDir()
@@ -34,26 +44,26 @@ func TestExecutor_ScoringJobFailsWithBadBinary(t *testing.T) {
 		}
 	}
 
-	// Build a Scorer that delegates to "false" — always exits 1.
-	scorer, err := libvmaf.New("false", "")
-	if err != nil {
-		// "false" must exist on the PATH in CI; skip rather than fail.
-		t.Skipf("could not locate 'false' binary: %v", err)
-	}
-
-	exec := NewExecutor(scorer, nil, "cpu", nil)
+	store := &mockStorage{mode: storage.ModeHTTPServe}
+	exec := NewExecutor(store, "false", nil) // "false" → exits 1 immediately, never actually runs vmaf
 
-	job := &controllerv1.Job{
-		Id: "test-001",
-		Scoring: &controllerv1.ScoringParams{
-			Reference: refPath,
-			Distorted: disPath,
-			Model:     "vmaf_v0.6.1",
-		},
+	// We do NOT expect a successful score here since "false" is not vmaf.
+	// We just verify that Prepare is called for both URIs without panics or
+	// data races, and that cleanup() defers are handled.
+	job := ScoringJob{
+		JobID:        "test-001",
+		ReferenceURI: refPath,
+		DistortedURI: disPath,
+		Width:        576,
+		Height:       324,
+		PixelFormat:  "yuv420p",
+		ModelPath:    "/models/vmaf_v0.6.1.json",
 	}
 
-	result := exec.Execute(context.Background(), job)
-	if result.Error == nil {
+	ctx := context.Background()
+	_, err := exec.Execute(ctx, job)
+	// We expect an error because "false" exits 1.
+	if err == nil {
 		t.Error("expected error from 'false' vmaf binary, got nil")
 	}
 }