Repository navigation
Conversation
lusoris
enabled auto-merge (squash)
May 29, 2026 11:27
lusoris
disabled auto-merge
May 29, 2026 11:43
lusoris
marked this pull request as draft
May 29, 2026 11:43
…-0800)
Introduce core/src/feature/gpu_slab.h with SLAB_FIELD(dst, type, slab)
which carries a single cited performance-no-int-to-ptr suppression
(ADR-0278 / ADR-0800) at the macro definition site.
Replace 21 bare NOLINT suppressions across:
- core/src/feature/hip/integer_vif_hip.c (15 init + 1 dispatch site)
- core/src/feature/cuda/integer_vif_cuda.c (15 init + 1 dispatch site)
- core/src/feature/cuda/integer_adm_cuda.c (NOLINTBEGIN/END block
covering 7 slab-carving helper functions)
Also fix pre-existing merge conflict markers in .semgrepignore (from
commit 24bb5da) that caused semgrep to crash with exit code 2 on
full-tree scans.
No math change. Fast test suite: 49/49 pass (CPU-only build).
ADR-0214 GPU-parity gate unaffected (no kernel change).
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
lusoris
force-pushed
the
worktree-agent-a00965aaca307979a
branch
from
May 29, 2026 12:13
9bf2dba to
cac7384
Compare
Contributor
Author
|
Contaminated (64 files) — needs reconstruction, skipping rebase per session policy |
lusoris
marked this pull request as ready for review
May 31, 2026 13:34
lusoris
marked this pull request as draft
May 31, 2026 13:54
lusoris
marked this pull request as ready for review
May 31, 2026 14:01
Contributor
Author
|
Closing as part of marathon cleanup 2026-05-31 (150 PRs merged today). Content likely superseded by sibling merges. Reopen if specific finding still needs work; bigger PRs preferred going forward per session feedback. |
Contributor
Author
lusoris
added a commit
that referenced
this pull request
Jun 3, 2026
…conflict Both source PRs were authored before sweep commit 24bb5da and produce unresolvable 3-way merge conflicts against master (40d192e). Adding the CHANGELOG fragment to satisfy the AHEAD >= 1 constraint and document the skipped items for future rebase/re-application. - #161: testdata hygiene (ADR-0813) — SKIPPED-CONFLICT (119 hunk sites) - #194: SLAB_FIELD macro refactor (ADR-0800) — SKIPPED-CONFLICT Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
lusoris
added a commit
that referenced
this pull request
Jun 3, 2026
…conflict (#521) Both source PRs were authored before sweep commit 24bb5da and produce unresolvable 3-way merge conflicts against master (40d192e). Adding the CHANGELOG fragment to satisfy the AHEAD >= 1 constraint and document the skipped items for future rebase/re-application. - #161: testdata hygiene (ADR-0813) — SKIPPED-CONFLICT (119 hunk sites) - #194: SLAB_FIELD macro refactor (ADR-0800) — SKIPPED-CONFLICT Co-authored-by: Lusoris <lusoris@pm.me> Co-authored-by: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
core/src/feature/gpu_slab.hwithSLAB_FIELD(dst, type, slab)macro that centralises theCUdeviceptr/uintptr_t→typed-pointer cast for GPU device-buffer carving.performance-no-int-to-ptrNOLINTs (violating ADR-0278) ininteger_vif_hip.c,integer_vif_cuda.c, andinteger_adm_cuda.cwithSLAB_FIELDcalls. The macro carries the single cited suppression at the definition site..semgrepignore(from24bb5daf89) that caused semgrep to crash with exit code 2 on full-tree scans.Deliverables checklist (ADR-0108)
AGENTS.mdinvariant note: added tocore/src/feature/cuda/AGENTS.mdandcore/src/feature/hip/AGENTS.mdmeson setup core/build --wipe -Denable_cuda=false -Denable_sycl=false && ninja -C core/build && meson test -C core/build --suite=fast(49/49 pass)changelog.d/fixed/0800-gpu-slab-nolint-citations.mddocs/rebase-notes.mdentry:gpu-slab-nolint-citations (2026-05-29, ADR-0800)State / bug tracking (ADR-0165)
No bug opened, closed, or ruled not-affecting. PR #127 finding resolved.
ffmpeg-patches (ADR-0186)
no ffmpeg-patches impact: internal header only, no public C API surface change.
🤖 Generated with Claude Code