Repository navigation
fix(sycl): prevent cross-TU kernel identity collisions - #1551
Merged
lusoris merged 1 commit intoSep 25, 2026
Merged
Conversation
lusoris
enabled auto-merge (squash)
September 24, 2026 11:04
lusoris
disabled auto-merge
September 24, 2026 20:27
lusoris
changed the base branch from
master
to
train/pre-rc1-correctness-20260924
September 24, 2026 20:28
lusoris
merged commit Sep 25, 2026
af7f60c
into
train/pre-rc1-correctness-20260924
93 of 94 checks passed
7 of 13 tasks
lusoris
added a commit
that referenced
this pull request
Oct 8, 2026
…9cb9479f2 The fork's records of its Netflix/vmaf pull requests and of the upstream defects it tracks were last checked on 2026-10-01. Upstream master has moved to 9cb9479f2 since, with the MSVC series, the arm64 ADM kernels, the fused SpEED filter and a rewrite of integer_compute_adm(). This brings the records up to date. No fork code and no score changes. - known-upstream-bugs.md: 42 open pull requests instead of 15, which of them needed a rebase or a rework against 9cb9479f2, the #1494 and best15 status, the integer AIM change upstream (cffd5b77d), the arm64 gap in #1602, and what is new upstream since the parity pin. The pin heading is unchanged. - state.md: dated updates on the rows for #1422, #1551 (both halves), #1602, #1605, #1635, #1636 and #955. - upstream_parity.d: the APSNR zero-error row also names #1618, which changes the same cap upstream; the allowlist page is regenerated. - rebase-notes.d: what a port of upstream's arm64 ADM code (8bc5a5c6a, b41d2340a) must not copy, and the closed state of #1551. Signed-off-by: Lusoris <lusoris@proton.me>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Prevent Intel Arc from linking a SpEED chroma host closure to the temporal device image by giving the two SYCL translation units distinct launcher identities. Restore the explicit
integer_moment_sycl.cppoutput-capture alias lost by the silent revert, and add a portable source-contract red cap for unique kernel names, fp64-free SpEED device regions, and explicit output captures.Type
fix— bug fixsycl/cuda/simd— backend-specificChecklist
make verify-all, strict MkDocs, pre-commit, and pre-push gates are green locally.1e-4tolerance.Bug-status hygiene
docs/state.mdclosesT-SYCL-SPEED-CHROMA-BOTH-SINGULAR-REGRESSED-2026-09-23with current executable evidence. BUG-048 remains open until its other independently owned restoration sections land and are reverified on master.Netflix golden-data gate
assertAlmostEqual(...)score was modified.Cross-backend numerical results
Deep-dive deliverables
docs/research/2090-sycl-silent-revert-residuals-2026-09-24.md.## Alternatives consideredrecords the five evaluated options and selected minimum repair.AGENTS.mdinvariant note —core/src/feature/sycl/AGENTS.mddocuments unique SpEED launcher identities and explicit output captures.changelog.d/fixed/sycl-silent-revert-residuals.md.docs/rebase-notes.mdrecords the SYCL kernel-identity/capture invariant.Reproducer
python3 core/test/test_sycl_kernel_source_contract.py -v ONEAPI_DEVICE_SELECTOR=level_zero:gpu meson test -C build-sycl \ test_sycl_speed_chroma_parity test_sycl_speed_temporal_parity \ test_sycl_speed_singular_parity test_sycl_float_moment_parity \ test_sycl_kernel_source_contract --print-errorlogsValidation
4e6916d16ac57647105d14a47a6680117d6b5738.1e-4.make verify-all, strict MkDocs, full changed-file pre-commit, state/changelog checks, and silent-revert checks passed.Surface opt-outs
no docs needed: internal SYCL kernel identity and capture repair with no user-discoverable surface change.
no ffmpeg-patches update needed: no public header, C API, CLI flag, Meson option, pkg-config surface, or shipped FFmpeg integration changed.
Known follow-ups
No performance tuning, tolerance adjustment, retraining, or unrelated BUG-048 restoration is part of this PR.