Repository navigation
ci(standards): move the praetor engine pin to main 846da59 and tighten the stale baseline - #1503
Merged
Merged
Conversation
…n the stale baseline standards-gate.yml installed praetor at e4b35cb3c7fe (2026-09-18). Main is at 846da5908d15. Before moving the pin, both engines -- and a clean go-install of 846da59, the form CI runs -- recorded the baseline on origin/master 551d35a: all three produce byte-identical infraction sets, 1414 entries with the same fingerprints. The bump changes no finding. The committed baseline said 1433 while the tree measures 1414. The 19 are two files cleaned in merged PRs without re-recording: core/src/svm.cpp 14 -> 0 (#1498) and core/test/test_ciede_neon.c 5 -> 0. A too-loose baseline fails nothing, so those entries were quietly headroom for 19 new findings (ledger L-80; filed upstream as cordanaLLM/praetor#349). Re-recorded here, in the PR that owns the engine, so the other open PRs stop each correcting it in passing.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
standards-gate.ymlinstalls praetor ate4b35cb3c7fe(praetor main as of 2026-09-18). Main is now846da5908d15. This moves the pin — and, because the workflow comment says "the baseline is recorded against this engine", it first proves the move changes nothing.The engine bump changes no finding
Three builds recorded
.standards-baseline.jsonon the identicalorigin/mastertree (551d35a63):e4b35cb3c7fe846da5908d15846da5908d15go install …/cmd/standardsctl@846da590…, exactly what this workflow runsThe three JSON files are byte-identical after dropping the timestamp — same fingerprints, same messages, same order.
praetorctl auditpasses under all three.The committed baseline was 19 looser than the tree
Every one of those recordings reported
Total: 1414 infractions, previously 1433. The 19 are two files cleaned in merged PRs without the same-PR re-record ADR-1142 asks for:core/src/svm.cppcore/test/test_ciede_neon.cA too-loose baseline fails nothing — the audit errors only on an increase, or on unmatched fingerprints in a touched file — so those entries were quietly headroom for 19 new findings. Ledger
L-80; reported upstream as cordanaLLM/praetor#349 (the audit should notice stale entries itself). Re-recorded here, in the PR that owns the engine, so #1499, #1500, #1501 and #1502 stop each correcting it in passing and conflicting with one another on the file.Verification
go installpraetorctl audit(new engine) on this branchType
ci— CI / tooling changeChecklist
assertAlmostEqual(...)score in the Netflix golden Python tests.docs/state.md: no row — no bug closed or opened in the fork's tracked set; the baseline drift is a ledger item (L-80) and an upstream praetor issue.Deep-dive deliverables (ADR-0108)
AGENTS.mdinvariant note — no rebase-sensitive invariants: a workflow env var and a generated JSON.Reproducer
Repeat with
@e4b35cb3c7fe7abe91554e3476e0ffd9caadbfa4anddiffthe two JSONs ignoringgenerated_at.