Repository navigation
Conversation
…e assertions Maintainer-authorized golden change (popup answer, 2026-09-19). The three assertAlmostEqual calls that expected 88.030322 on macOS and 88.030463 elsewhere now expect 88.030463 everywhere. After the September upstream reconciliation (#1473) macOS produces 88.030459. That is within places=4 of the Linux value and not of the old Darwin value, so the special case had become the thing failing the macOS lanes: test_run_vmafexec_runner_akiyo_multiply_disable_enhn_gain, _no_enhn_gain_model and _with_feature_enhn_gain_limit, each with '88.030459 != 88.030322 within 4 places'. Exactly three lines change. The other three per-platform values in this file (132.73, 129.47, 122.80) still measure as recorded and are untouched, and _IS_DARWIN stays for them.
lusoris
added a commit
that referenced
this pull request
Sep 19, 2026
…e assertions Maintainer-authorized golden change (popup answer, 2026-09-19), folded into the upstream reconciliation because it is only true together with it: with this port macOS produces 88.030459, within places=4 of the Linux value 88.030463 and not of the old Darwin value 88.030322, so the special case was what failed the four macOS lanes on this PR. Without the port macOS still yields 88.030317, which is why the change could not merge on its own (#1502, closed in favour of this commit). Exactly three assertion lines change. The other three per-platform values in the file still measure as recorded and are untouched.
Contributor
Author
|
Folded into #1473 as commit This change is only true together with the September upstream reconciliation. On Same three lines, same maintainer authorization, now carried by the PR that makes them correct. |
21 of 27 tasks
lusoris
added a commit
that referenced
this pull request
Sep 20, 2026
…e assertions Maintainer-authorized golden change (popup answer, 2026-09-19), folded into the upstream reconciliation because it is only true together with it: with this port macOS produces 88.030459, within places=4 of the Linux value 88.030463 and not of the old Darwin value 88.030322, so the special case was what failed the four macOS lanes on this PR. Without the port macOS still yields 88.030317, which is why the change could not merge on its own (#1502, closed in favour of this commit). Exactly three assertion lines change. The other three per-platform values in the file still measure as recorded and are untouched.
lusoris
added a commit
that referenced
this pull request
Sep 20, 2026
…e assertions Maintainer-authorized golden change (popup answer, 2026-09-19), folded into the upstream reconciliation because it is only true together with it: with this port macOS produces 88.030459, within places=4 of the Linux value 88.030463 and not of the old Darwin value 88.030322, so the special case was what failed the four macOS lanes on this PR. Without the port macOS still yields 88.030317, which is why the change could not merge on its own (#1502, closed in favour of this commit). Exactly three assertion lines change. The other three per-platform values in the file still measure as recorded and are untouched.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR edits Netflix golden assertions. It does so on the maintainer's explicit authorization (popup answer, 2026-09-19: "Explicitly authorize me to edit them"), and it is the only PR in the queue that touches
python/test/.Three
assertAlmostEqualcalls inpython/test/vmafexec_test.py(lines 941, 1051, 1107) expected88.030322on macOS and88.030463elsewhere. After the September upstream reconciliation (#1473) macOS produces88.030459, which is withinplaces=4of the Linux value and not of the old Darwin value — so the special case itself had become the thing failing the four macOS lanes on #1473, #1474, #1476, #1477, #1478 and #1481:Those three lines now expect
88.030463everywhere. Exactly three assertion lines change. The other three per-platform values in the file (132.73…,129.47…,122.80…) are not failing, still measure as recorded, and are untouched;_IS_DARWINstays for them. The ADR-0418 header comment gains a note recording the change and why.What this is not
places=4is unchanged on every assertion.88.030463is the value the Linux lanes have asserted all along.core/moves.Verification
master88.030463vs88.030459, Δ 4e-6, insideplaces=4praetorctl audit.standards-baseline.jsonis re-recorded (line shifts in this file are line-keyed); it lands at 1414, which is whatorigin/masteractually measures — see ledgerL-80and #1499 for why the committed 1433 was loose.Type
test— test-only changeChecklist
assertAlmostEqual(...)values in the Netflix golden Python tests — with the maintainer's explicit authorization, recorded above and in the commit message.docs/state.md: no row — this closes no bug and opens none; it unblocks the six PRs listed above.Deep-dive deliverables (ADR-0108)
AGENTS.mdinvariant note — no rebase-sensitive invariants: an upstream sync never touches this fork-local test file.Reproducer
On a macOS host with #1473 applied: fails on
master(three!= 88.030322assertions), passes here.