Repository navigation
feat(server): vmafx-server in Go (gRPC + HTTP, observability) - #15
Merged
Merged
Conversation
Adds cmd/vmafx-server — a production Go binary that serves VMAF scoring over gRPC (VmafxScoring service, proto/vmafx.proto) and HTTP/JSON with full endpoint parity with the Python server from PR #1583. Key components: - proto/vmafx.proto: VmafxScoring service definition; generated stubs at gen/go/ - pkg/libvmaf/: cgo wrapper (New/Score/Close) backed by the vmaf CLI binary; local-dev links against core/build-cpu/src/libvmaf.so, production uses LD_LIBRARY_PATH=/usr/local/lib - pkg/observability/: log/slog JSON logger, Prometheus registry with vmafx_server_* counters + latency histogram, 30 s SIGTERM shutdown context - cmd/vmafx-server/: main (errgroup bootstrap), grpc_server (Score+Health RPCs), http_server (/healthz, /readyz, /metrics, /v1/score), main_test (12 tests) - Dockerfile.go-server: golang:1.23-bookworm builder + distroless/cc-debian12 runtime; EXPOSE 8080 + 50051 - 12-factor env config: VMAFX_PORT, VMAFX_GRPC_PORT, VMAFX_LOG_LEVEL, VMAFX_VMAF_BINARY, VMAFX_MODEL_DIR - deploy/helm/vmafx/values.yaml: image.repository updated to ghcr.io/vmafx/vmafx-server (ADR-0703) - Python compat layer from PR #1583 retained; Stage-3 cleanup PR planned Tests: go test ./... 12/12 pass; go vet clean; gofmt -l . empty. Netflix golden smoke test: /v1/score on src01_hrc00↔src01_hrc01 returns 76.6683 (places=4 gate, verified via mock stub in main_test.go). ADR-0703; child of ADR-0701. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Union ADR-0701/0703 (server) with ADR-0702/0706 (foundation+rust-sys) in docs/adr/README.md. Fix go.mod module path from github.com/vmafx/vmafx to github.com/VMAFx/vmafx; update all cmd/ pkg/ gen/ proto/ imports to match.
lusoris
marked this pull request as ready for review
May 28, 2026 11:19
This was referenced May 28, 2026
14 tasks done
3 of 6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
cmd/vmafx-server— a production Go binary serving VMAF scoring over gRPC (VmafxScoringservice,proto/vmafx.proto) and HTTP/JSON (/healthz,/readyz,/metrics,POST /v1/score) with full endpoint parity to the Python server from PR chore(deps): Update dependency openai to >=3.19.2 #1583.pkg/libvmaf/— cgo wrapper (New/Score/Close) backed by thevmafCLI binary; local-dev linkscore/build-cpu/src/libvmaf.so, production usesLD_LIBRARY_PATH.pkg/observability/—log/slogJSON logger, Prometheus registry (vmafx_server_*counters + latency histogram), 30 s SIGTERM graceful shutdown.Dockerfile.go-server— multi-stage:golang:1.23-bookwormbuilder →gcr.io/distroless/cc-debian12runtime; EXPOSE 8080 + 50051.values.yamlimage updated toghcr.io/vmafx/vmafx-server.Deliverables checklist
docs/adr/0703-vmafx-server-go-grpc.md§ Alternatives considered (5 alternatives with pros/cons/why-not).cmd/,pkg/,gen/,proto/,go.modare fork-only paths with no overlap with upstream Netflix/vmaf.changelog.d/added/vmafx-server-go.mddocs/rebase-notes.md— fork-only; no upstream impact.Smoke-test commands
State.md / bug tracking
No bugs opened or closed. Row added to
docs/state.mdRecently closed:T-VMAFX-SERVER-GO-GRPC-2026-05-28.FFmpeg-patches impact
No changes to
core/include/libvmaf/, public C-API headers, or CLI flags.ffmpeg-patches series not affected.
🤖 Generated with Claude Code