Repository navigation
Conversation
This was referenced Sep 8, 2026
Contributor
Author
|
Superseded by the pre-rc.1 fixing train in #1425, which carries this work. Closing rather than leaving it open, because the ADR Collision Guard — a required check — fails #1425 while two open PRs claim the same ADR number. The guard is right that they collide; it cannot tell that one of them contains the other. Verified before closing, not assumed: every ADR file this branch adds is byte-identical in #1425 (sha256 compared), and the branch's commits were replayed onto the train individually, with each conflict resolved by hand and recorded in the commit messages. The branch is untouched, so this is reversible — reopen if #1425 is abandoned. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The local train promoted stacked PR #1420, reused an active agent checkout, and merged it into #1396 after its rebase push failed. Route promotion, rebase, and merge through one tracked guard that requires a master target, honors holds and source ownership on every action, and stops promotion after any rebase/push failure.
Merges require a receipt generated by executing full
make lintandmake teston the exact clean PR head, plus present, passing required hosted checks. A separate migration helper previews an exact hashed plan, preserves original scripts/holds, and installs paused adapters with gateway hash checks and read-only observer defaults. The operator guide isdocs/development/merge-train.md.This PR remains draft and held. Source publication does not deploy the runtime or establish RC1 readiness.
Type
fix— local merge-train control and ownership bugsbuild/ci— developer automationValidation
make lintandmake testhave not been run successfully for this head. The fixture Make commands validate the runner's behavior; they are not native VMAFx, backend, golden-data, or full local-gate acceptance.Checklist
make lintandmake testare green locally for this exact head — still required before merge.Bug-status hygiene
docs/state.mdrecords T-MERGE-TRAIN-CONTROL-2026-09-08 and leaves runtime migration open until independently evidenced.Netflix golden-data gate
assertAlmostEqual(...)score was modified.Deep-dive deliverables
docs/research/merge-train-control-2026-09-08.mdrecords the incident, installed-tool semantics, experiments, and limits.docs/adr/1244-merge-train-ownership-and-validation.md, Alternatives considered.AGENTS.mdinvariant note —scripts/dev/AGENTS.mdpreserves shared guards, full-gate receipts, failure propagation, and explicit runtime migration.changelog.d/fixed/merge-train-ownership-guard.md.docs/rebase-notes.md, local control boundary entry.Reproducer
python3 -m unittest discover -s scripts/dev/tests -p 'test_*merge_train_guard.py'Known follow-ups and migration
--apply --expect-plan SHA256. The installed watchdog/operator remain read-only;PAUSEDremains present..workingdir2/evidence/2026-09-08-merge-train-control/; it includes original runtime snapshots, fixture results, normal-hook logs, and the preview plan. That plan is not an installation or release-acceptance receipt.Reviewed runtime migration update — 2026-09-08
The coordinating operator has now completed the runtime migration from this exact source head,
adacaa9a1beb2806efd13ac42ad52a214e2b63a4, using reviewed plan5dfaecc7e07c4c60305d3c3fcbf2cb4b1c4042ae4721479f829932b953a4d0d2. The installed gateway hash is9ed100056bb7d98b89d080066b61dfbebe90de4db6d1d7fa38f18a110acec977..claude/mergetrain/migration-6wtg48lv/. Holds were preserved andPAUSEDremains present.Detailed plan, installation, identity, before/after PR, and observer receipts are retained under
.workingdir2/evidence/2026-09-08-merge-train-control/runtime-migration/. This supersedes the earlier runtime-migration-pending status only; no source changed. The 26 control/migration tests remain passing, but full repositorymake lintandmake testfor this guard head remain unverified. This runtime repair does not establish RC1 readiness or permit merging this held draft.