Repository navigation
docs(state): close T-NEON-FMA-FLOAT-ADM-DWT2-2026-06-06 in the ledger - #1331
Merged
Merged
Conversation
lusoris
force-pushed
the
docs/close-t-neon-fma-float-adm-dwt2-2026-06-06
branch
3 times, most recently
from
September 6, 2026 09:35
2706b80 to
df968a5
Compare
The ledger row for T-NEON-FMA-FLOAT-ADM-DWT2-2026-06-06 was self-contradictory: a 2026-06-27 note inside the T-MASTER-CI-TSAN-ARM-GOLDEN-2026-06-27 row said the bug "stays Open" for a correct re-attempt, while its Recently-closed row already recorded a 2026-08-30 closure — and that closure narrative described only the integer-path dropped-tap defect and cited a branch name (`fix/adr-1057-arm-fma-drift`) instead of a commit. Re-verified against origin/master, with no defective code left to point at: - The float-ADM follow-up the row asked for landed in `a6c4dfffb` (PR #853): the kernel lives in a dedicated non-contracting TU `core/src/feature/arm64/float_adm_dwt2_neon.c`, built with `-ffp-contract=off` (`core/src/meson.build`), and `adm_dwt2_dispatch()` in `core/src/feature/adm.c` calls `float_adm_dwt2_neon()` under `VMAF_ARM_CPU_FLAG_NEON`. The scalar `adm_dwt2_s` carries the matching function-scoped guard, so both sides of the comparison are non-contracting and the 1-ULP FMA gap that motivated the row cannot arise. - The integer `idx < 3` dropped filter tap in `adm_dwt2_8_neon` was fixed by `a013c1410` (PR #1134) and hardened to bit-exactness by `89a8e3258` (PR #1154); `6d61106ed` (PR #1156) added NEON parity tests for the remaining uncovered kernels. - `core/test/test_float_adm_dwt2_neon.c` gates NEON-vs-scalar bit-exactness by bit pattern and is registered in the default `fast` suite. The row stays in "Recently closed" (exactly one row for the id), rewritten in past tense with real commit shas, and the stale "stays Open" note is marked superseded so the next session does not re-investigate. Documentation only — no code or behaviour change. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
lusoris
force-pushed
the
docs/close-t-neon-fma-float-adm-dwt2-2026-06-06
branch
from
September 7, 2026 06:55
df968a5 to
192a794
Compare
lusoris
marked this pull request as ready for review
September 7, 2026 07:19
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Ledger-only correction. The
docs/state.mdrow forT-NEON-FMA-FLOAT-ADM-DWT2-2026-06-06was self-contradictory: a 2026-06-27 note inside theT-MASTER-CI-TSAN-ARM-GOLDEN-2026-06-27row said the bug "stays Open" for a correct re-attempt, while its Recently-closed row already recorded a 2026-08-30 closure — and that closure narrative described only the integer-path dropped-tap defect and cited a branch name (fix/adr-1057-arm-fma-drift) instead of a commit. Re-verified againstorigin/master: there is no defective code left to point at, so the row is rewritten in past tense with real commit shas and the stale "stays Open" note is marked superseded. No code or behaviour change.Type
docs— documentation onlyno docs needed: the diff touches only
docs/state.md,changelog.d/changed/t-neon-fma-float-adm-dwt2-ledger-correction.mdand the regeneratedCHANGELOG.md— no CLI flag, public header, meson option, feature extractor, backend, MCP tool or output schema is added or changed.Verification
a6c4dfffb(PR fix: 6 real-code-fix bundle (matrix-v2 follow-up + NEON FMA re-dispatch) #853) put the kernel in a dedicated non-contracting TUcore/src/feature/arm64/float_adm_dwt2_neon.c, compiled with-ffp-contract=off(core/src/meson.build:722-759), and re-wiredadm_dwt2_dispatch()incore/src/feature/adm.cto callfloat_adm_dwt2_neon()underVMAF_ARM_CPU_FLAG_NEON. The scalaradm_dwt2_s(core/src/feature/adm_tools.c) carries the matching function-scoped guard (__attribute__((optimize("-ffp-contract=off")))for GCC,#pragma clang fp contract(off)in the body for Clang) — deliberately function-scoped, since the file-scoped variant is what made PR fix(arm64): FMA-safe float-ADM DWT2 bit-exactness — guard scalar adm_dwt2_s (closes T-NEON-FMA, ADR-1057) #1060 drift the akiyo golden and get reverted by fix(ci): repair master red — TSan operator-new dup + revert #1060 ARM golden drift #1063. Both sides are non-contracting, so the 1-ULP FMA gap that motivated the row cannot arise.core/src/feature/arm64/adm_neon.cnow loopsfor (int idx = 0; idx < 4; idx++)at both sites (lines 181, 260); theidx < 3dropped 4th filter tap was fixed bya013c1410(PR fix(arm64): adm_dwt2_8_neon dropped the 4th filter tap at j=0 (ADR-1057 rediagnosed) #1134) and hardened to bit-exactness by89a8e3258(PR fix(arm64): make adm_dwt2_8_neon bit-exact with the scalar kernel #1154), with6d61106ed(PR fix(arm64): NEON parity tests for every uncovered kernel, and 7 defects they found #1156) adding NEON parity tests for the remaining uncovered kernels.core/test/test_float_adm_dwt2_neon.cruns the productionadm_dwt2_sandfloat_adm_dwt2_neonon the same input and assertsmismatches == 0by bit pattern (not==), plus a geometry sweep and a signed-zero case; registered incore/test/meson.buildastest('test_float_adm_dwt2_neon', …, suite : ['fast', 'simd']).Exactly one ledger row exists for the bug id, in
## Recently closed.Bug-status hygiene (ADR-0165)
docs/state.mdupdated in this PR — theT-NEON-FMA-FLOAT-ADM-DWT2-2026-06-06row in## Recently closedis rewritten in past tense citinga6c4dfffb/a013c1410/89a8e3258/6d61106ed/195f88a22, the Open-section tombstone comment is updated to the same shas, and the stale "stays Open" sentence in theT-MASTER-CI-TSAN-ARM-GOLDEN-2026-06-27row is marked superseded.Netflix golden-data gate (ADR-0024)
assertAlmostEqual(...)score in the Netflix golden Python tests.Deep-dive deliverables (ADR-0108)
AGENTS.mdinvariant note — no rebase-sensitive invariants.changelog.d/changed/t-neon-fma-float-adm-dwt2-ledger-correction.md;CHANGELOG.mdregenerated withbash scripts/release/concat-changelog-fragments.sh --write.Reproducer
Known follow-ups
None.
T-NEON-FMA-FLOAT-ADM-DWT2-REVERT-2026-06-06(the separate revert-tracking row) already sat in## Recently closedand is unchanged.