Repository navigation
fix(tune): omit -crf in libx264 two-pass encoding and update state.md - #1265
Merged
Merged
Conversation
lusoris
force-pushed
the
fix/vmaftune-state-bugs
branch
from
September 4, 2026 18:50
270511e to
87c7aa2
Compare
lusoris
marked this pull request as ready for review
September 4, 2026 19:01
lusoris
force-pushed
the
fix/vmaftune-state-bugs
branch
from
September 4, 2026 19:13
87c7aa2 to
f689203
Compare
In two-pass encoding, FFmpeg libx264 rate control rejects -crf with "CRF/CQP is incompatible with 2pass" (exit status 187). Omit -crf in multi-pass mode across Go and Python codec adapters so two-pass invocations emit valid FFmpeg commands, and update state.md closing T-VMAFTUNE-TWOPASS-CRF-INVALID-2026-08-30 and recording verification of T-SPEED-GPU-REGISTRY-ORPHAN-2026-06-19.
lusoris
force-pushed
the
fix/vmaftune-state-bugs
branch
from
September 4, 2026 19:59
f689203 to
9f8e129
Compare
This was referenced Sep 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes open bug
T-VMAFTUNE-TWOPASS-CRF-INVALID-2026-08-30fromdocs/state.mdwherelibx264multi-pass encoding emitted conflicting rate control flags (-crfand-pass), causing FFmpeg to reject pass 2 (CRF/CQP is incompatible with 2pass.). In multi-pass mode (pass_number != 0),-crfis omitted across both Go (pkg/codecadapter,pkg/ffencode,pkg/corpus) and Python (vmaftune.codec_adapters.x264,vmaftune.encode). Also records verification ofT-SPEED-GPU-REGISTRY-ORPHAN-2026-06-19, which was already resolved onmastervia PR #1004 (commita0bf83c214).Type
fix— bug fixChecklist
make format && make lintis green locally.meson test -C build./cross-backend-diffand the worst ULP is <= 2..c/.cpp/.cu/.h/.hpp, it has the appropriate license header (seeCONTRIBUTING.md).!orBREAKING CHANGE:and the migration path is documented below.docs/adr/_index_fragments/<NNNN-slug>.mdand the slug is appended todocs/adr/_index_fragments/_order.txt— do not editdocs/adr/README.mddirectly (regenerated byscripts/docs/concat-adr-index.sh; see ADR-0221).Bug-status hygiene (ADR-0165)
docs/state.mdupdated in this PR with rows in Recently closed forT-VMAFTUNE-TWOPASS-CRF-INVALID-2026-08-30andT-SPEED-GPU-REGISTRY-ORPHAN-2026-06-19.Netflix golden-data gate (ADR-0024)
assertAlmostEqual(...)score in the Netflix golden Python tests.Deep-dive deliverables (ADR-0108)
changelog.d/fixed/vmaftune-twopass-crf-conflict.mdadded.docs/rebase-notes.mdupdated with entry forfix/vmaftune-state-bugs.Reproducer
go test -v ./pkg/ffencode/... ./pkg/codecadapter/... ./pkg/corpus/... pytest tools/vmaf-tune/tests/test_codec_adapter_x265_two_pass.py -v