Repository navigation
chore(renovate): never digest-pin the SLSA generator; bump the Intel NEO stack as a set - #1188
Merged
Merged
Conversation
1 task
…NEO stack as a set Two train PRs could never merge, for reasons Renovate cannot know: - #1183 digest-pinned slsa-framework/slsa-github-generator. The generator's README says its reusable workflows MUST be referenced by an exact @vX.Y.Z tag so slsa-verifier can verify the trusted builder (hash-pinned reusable workflows are unsupported, slsa-verifier#12), and the Release Script Contract check (scripts/release/tests/test-publication-environment-binding.sh) enforces the tag form. pinDigests: false for that package; tag bumps still flow. - #1184 bumped intel/gmmlib alone. dev/Containerfile fetches libigdgmm12_${GMMLIB_VER} and the IGC debs from the intel/compute-runtime release page for NEO_VER, so a lone gmmlib bump yields a 404 in the Dev Container Build. compute-runtime, intel-graphics-compiler, gmmlib and level-zero are now one Renovate group; manual review stays (ADR-0605). Verified: renovate.json parses; the untouched release-contract validator still passes on master's tag-form supply-chain.yml. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
go-ci.yml pinned go-version: "1.27.0" while go.mod's directive is what Renovate bumps, and GOTOOLCHAIN=local forbids auto-download — so #1139 (go 1.27.0 -> 1.27.1) failed go vet + go test with: go: go.mod requires go >= 1.27.1 (running go 1.27.0; GOTOOLCHAIN=local) Every setup-go step now uses go-version-file: go.mod. actionlint finding count unchanged vs master. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
lusoris
force-pushed
the
fix/renovate-train-hygiene
branch
from
September 2, 2026 14:48
c7f99fe to
b892540
Compare
1 task
lusoris
marked this pull request as ready for review
September 2, 2026 14:49
scripts/release/concat-changelog-fragments.sh --check (Release Script Contract, ADR-1128) fails when a fragment is added without re-rendering CHANGELOG.md. Rendered with --write, not hand-edited (ADR-0221). Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
This was referenced Sep 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Two Renovate PRs in today's train could never merge, for reasons Renovate cannot know; this teaches it.
slsa-framework/slsa-github-generator. Its README: the generators "MUST be referenced by tag in order for theslsa-verifierto be able to verify the ref of the trusted builder" (hash-pinned reusable workflows unsupported, slsa-verifier#12). TheRelease Script Contractcheck enforces the tag form. →pinDigests: falsefor that package; tag bumps still flow.intel/gmmlibalone.dev/Containerfiledownloadslibigdgmm12_${GMMLIB_VER}and the IGC debs from the compute-runtime release page forNEO_VER, so a lone bump 404s (curl: (22)), turningDev Container Buildred. →compute-runtime+intel-graphics-compiler+gmmlib+level-zeroare one group. Manual review stays (ADR-0605).Type
build/ci— tooling / infraChecklist
make format && make lintis green locally.meson test -C build./cross-backend-diffand the worst ULP is ≤ 2..c/.cpp/.cu/.h/.hpp, it has the appropriate license header.!orBREAKING CHANGE:and the migration path is documented below.docs/adr/_index_fragments/.Config-only; no source, test, or compute path touched.
Bug-status hygiene (ADR-0165)
docs/state.mdupdated in this PR with a rowno state delta: dependency-bot configuration only, no libvmaf bug opened or closed.
Netflix golden-data gate (ADR-0024)
assertAlmostEqual(...)score in the Netflix golden Python tests.Cross-backend numerical results
Not applicable.
Deep-dive deliverables (ADR-0108)
AGENTS.mdinvariant note — no rebase-sensitive invariants.changelog.d/changed/renovate-train-hygiene.md.renovate.jsonis fork-local.Reproducer
Known follow-ups
Breaking changes / migration
None.
🤖 Generated with Claude Code