Repository navigation
fix(containers): repair GPU builds and model layout - #1180
Merged
Merged
Conversation
1 task
This was referenced Aug 31, 2026
5 of 7 tasks
lusoris
added a commit
that referenced
this pull request
Oct 1, 2026
…DR-1429) (#1753) * docs(api): state what an index gap and a query before the flush do (ADR-1429) vmaf_read_pictures() rejects a repeated or earlier index with -EINVAL and accepts an index that skips values; after such a gap the motion extractors write no motion2 / motion3 for the later pictures. A score asked for before the flush returns the value or -EAGAIN. libvmaf.h and docs/api now say both, and the state ledger records that Netflix/vmaf#910, #755 and #1180 do not reproduce as wrong values on the fork. * docs: regenerate the indexes and the citation map after rebasing
2 of 7 tasks
lusoris
added a commit
that referenced
this pull request
Oct 1, 2026
…23e8f2 (#1761) * docs: record the fork's check of the upstream defects verified on 6ec23e8f2 Fifteen defects reproduced on Netflix master were run against the fork: three reproduced and are fixed (#1305, #1420 as a hang, #1613), two are documented (#910, #755 and #1180), ten are not affected. The dated section in known-upstream-bugs.md and the Confirmed not-affected rows of the state ledger carry the evidence; Netflix 8e7a1ac4e (revert of #1476) needs nothing from the fork. * docs: regenerate the indexes and the citation map after rebasing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Replace Renovate PR #1178 with a release-tested oneAPI builder update. The
production image now builds with Intel's digest-pinned Base Toolkit 2025.3.2
image while truthfully retaining Intel's latest published Ubuntu 24.04 runtime,
2025.3.1. The first exact build exposed Ubuntu's stale Meson 1.3.2 package, so
all three GPU builders now install one checksum-pinned Meson 1.12.0 wheel and
assert the installed version before compiling. A real score smoke also exposed
and fixes a shared extra-
model/directory that made the documented model pathabsent in every production target.
Type
build/ci— tooling / infrasycl/cuda/simd— backend-specificChecklist
vmaf --versionentrypoint as version 3.2.1; all four production targetsscore the fixed 48-frame fixture through the documented bundled model path.
docker buildx build --check, targeted pre-commit,git diff --check,and
mkdocs build --strictare green locally.Bug-status hygiene
changing a tracked product bug.
Netflix golden-data gate
assertAlmostEqual(...)score in the Netflixgolden Python tests.
Deep-dive deliverables
docs/research/20260831-oneapi-2025-3-2-builder-runtime-compatibility.mdrecords live registry, PyPI, build, and runtime evidence.AGENTS.mdinvariant note — no rebase-sensitive invariants: the existing production-container pin policy remains unchanged.changelog.d/changed/oneapi-2025-3-2-builder.md.docs/rebase-notes.md.Reproducer
Review evidence
resolved by mounting the wheel stage into each install step instead of
copying and deleting the wheel. Gemini 3.7 Flash's bounded final-patch
re-review returned
CLEAN.finding. An in-image
lddgate then resolved every dependency of bothvmafandlibvmaf.so.3, includinglibsycl.so.8,libur_loader.so.0, andthe Intel math runtimes; the executable smoke also remained green. Its two
low findings are intentionally contained: the remote wheel is content-locked
by SHA-256 with provenance recorded in the digest, and pip changes only a
disposable builder stage whose installed Meson version is asserted. Its
bounded final-diff re-review returned
CLEAN.Known follow-ups
Intel has not published
oneapi-runtime:2025.3.2-0-devel-ubuntu24.04. Theruntime remains explicitly pinned to 2025.3.1 until that exact vendor image
exists and passes the same final-image smoke test.